mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Linus Walleij <linusw@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg
Date: Tue, 20 Jan 2026 15:28:43 +0200	[thread overview]
Message-ID: <c52378b8-1690-42cc-a7dd-f938dcbfa708@intel.com> (raw)
In-Reply-To: <20260120-mmc-no-advert-v3-1-1c7a6a55ef9c@kernel.org>

On 20/01/2026 15:05, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
> 
> Drop all messages from sdhci_drv_init(), and drop the
> module_init() and module_exit() calls as well since they
> now become empty.
> 
> The modules becomes a pure library module, meaning it will
> get pulled in by modprobe() when the symbols inside it
> are needed, or compiled in if any users are compiled in.
> Kconfig already makes sure this module is compiled in
> the users are compiled in.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> Changes in v3:
> - Rebased on v6.19-rc1
> - Link to v2: https://lore.kernel.org/r/20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org
> 
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
>  drivers/mmc/host/sdhci.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af7..1ff15fa9b042 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4997,22 +4997,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>   *                                                                           *
>  \*****************************************************************************/
>  
> -static int __init sdhci_drv_init(void)
> -{
> -	pr_info(DRIVER_NAME
> -		": Secure Digital Host Controller Interface driver\n");
> -	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
> -	return 0;
> -}
> -
> -static void __exit sdhci_drv_exit(void)
> -{
> -}
> -
> -module_init(sdhci_drv_init);
> -module_exit(sdhci_drv_exit);
> -
>  module_param(debug_quirks, uint, 0444);
>  module_param(debug_quirks2, uint, 0444);
>  
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
> 
> Best regards,


  reply	other threads:[~2026-01-20 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 13:05 Linus Walleij
2026-01-20 13:28 ` Adrian Hunter [this message]
2026-01-22 18:03 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c52378b8-1690-42cc-a7dd-f938dcbfa708@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®