mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg
@ 2026-01-20 13:05 Linus Walleij
  2026-01-20 13:28 ` Adrian Hunter
  2026-01-22 18:03 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2026-01-20 13:05 UTC (permalink / raw)
  To: Adrian Hunter, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Linus Walleij

From: Linus Walleij <linus.walleij@linaro.org>

As much as we have grown used to seeing this message on
every kernel boot, it does not add any technical value.

Drop all messages from sdhci_drv_init(), and drop the
module_init() and module_exit() calls as well since they
now become empty.

The modules becomes a pure library module, meaning it will
get pulled in by modprobe() when the symbols inside it
are needed, or compiled in if any users are compiled in.
Kconfig already makes sure this module is compiled in
the users are compiled in.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v3:
- Rebased on v6.19-rc1
- Link to v2: https://lore.kernel.org/r/20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org

Changes in v2:
- Drop all the messages instead of demoting.
- Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
---
 drivers/mmc/host/sdhci.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ac7e11f37af7..1ff15fa9b042 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -4997,22 +4997,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
  *                                                                           *
 \*****************************************************************************/
 
-static int __init sdhci_drv_init(void)
-{
-	pr_info(DRIVER_NAME
-		": Secure Digital Host Controller Interface driver\n");
-	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
-
-	return 0;
-}
-
-static void __exit sdhci_drv_exit(void)
-{
-}
-
-module_init(sdhci_drv_init);
-module_exit(sdhci_drv_exit);
-
 module_param(debug_quirks, uint, 0444);
 module_param(debug_quirks2, uint, 0444);
 

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251007-mmc-no-advert-8f5646c44dd6

Best regards,
-- 
Linus Walleij <linusw@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg
  2026-01-20 13:05 [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg Linus Walleij
@ 2026-01-20 13:28 ` Adrian Hunter
  2026-01-22 18:03 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2026-01-20 13:28 UTC (permalink / raw)
  To: Linus Walleij, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Linus Walleij

On 20/01/2026 15:05, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
> 
> Drop all messages from sdhci_drv_init(), and drop the
> module_init() and module_exit() calls as well since they
> now become empty.
> 
> The modules becomes a pure library module, meaning it will
> get pulled in by modprobe() when the symbols inside it
> are needed, or compiled in if any users are compiled in.
> Kconfig already makes sure this module is compiled in
> the users are compiled in.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> Changes in v3:
> - Rebased on v6.19-rc1
> - Link to v2: https://lore.kernel.org/r/20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org
> 
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
>  drivers/mmc/host/sdhci.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af7..1ff15fa9b042 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4997,22 +4997,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>   *                                                                           *
>  \*****************************************************************************/
>  
> -static int __init sdhci_drv_init(void)
> -{
> -	pr_info(DRIVER_NAME
> -		": Secure Digital Host Controller Interface driver\n");
> -	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
> -	return 0;
> -}
> -
> -static void __exit sdhci_drv_exit(void)
> -{
> -}
> -
> -module_init(sdhci_drv_init);
> -module_exit(sdhci_drv_exit);
> -
>  module_param(debug_quirks, uint, 0444);
>  module_param(debug_quirks2, uint, 0444);
>  
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
> 
> Best regards,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg
  2026-01-20 13:05 [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg Linus Walleij
  2026-01-20 13:28 ` Adrian Hunter
@ 2026-01-22 18:03 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2026-01-22 18:03 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Adrian Hunter, linux-mmc, linux-kernel, Linus Walleij

On Tue, 20 Jan 2026 at 14:05, Linus Walleij <linusw@kernel.org> wrote:
>
> From: Linus Walleij <linus.walleij@linaro.org>
>
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
>
> Drop all messages from sdhci_drv_init(), and drop the
> module_init() and module_exit() calls as well since they
> now become empty.
>
> The modules becomes a pure library module, meaning it will
> get pulled in by modprobe() when the symbols inside it
> are needed, or compiled in if any users are compiled in.
> Kconfig already makes sure this module is compiled in
> the users are compiled in.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Changes in v3:
> - Rebased on v6.19-rc1
> - Link to v2: https://lore.kernel.org/r/20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org
>
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
>  drivers/mmc/host/sdhci.c | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af7..1ff15fa9b042 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4997,22 +4997,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>   *                                                                           *
>  \*****************************************************************************/
>
> -static int __init sdhci_drv_init(void)
> -{
> -       pr_info(DRIVER_NAME
> -               ": Secure Digital Host Controller Interface driver\n");
> -       pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
> -       return 0;
> -}
> -
> -static void __exit sdhci_drv_exit(void)
> -{
> -}
> -
> -module_init(sdhci_drv_init);
> -module_exit(sdhci_drv_exit);
> -
>  module_param(debug_quirks, uint, 0444);
>  module_param(debug_quirks2, uint, 0444);
>
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
>
> Best regards,
> --
> Linus Walleij <linusw@kernel.org>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-22 18:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-20 13:05 [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg Linus Walleij
2026-01-20 13:28 ` Adrian Hunter
2026-01-22 18:03 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®