* [PATCH] [media] include/media: fix missing | operator when setting cfg @ 2018-04-18 15:06 ` Colin King 2018-04-18 15:20 ` Sylwester Nawrocki 0 siblings, 1 reply; 5+ messages in thread From: Colin King @ 2018-04-18 15:06 UTC (permalink / raw) To: Kyungmin Park, Sylwester Nawrocki, Mauro Carvalho Chehab, Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel, linux-samsung-soc Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987 ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/media/platform/exynos4-is/fimc-lite-reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/exynos4-is/fimc-lite-reg.c index f0acc550d065..16565a0b4bf1 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite-reg.c +++ b/drivers/media/platform/exynos4-is/fimc-lite-reg.c @@ -254,7 +254,7 @@ void flite_hw_set_dma_window(struct fimc_lite *dev, struct flite_frame *f) /* Maximum output pixel size */ cfg = readl(dev->regs + FLITE_REG_CIOCAN); cfg &= ~FLITE_REG_CIOCAN_MASK; - cfg = (f->f_height << 16) | f->f_width; + cfg |= (f->f_height << 16) | f->f_width; writel(cfg, dev->regs + FLITE_REG_CIOCAN); /* DMA offsets */ -- 2.17.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] include/media: fix missing | operator when setting cfg 2018-04-18 15:06 ` [PATCH] [media] include/media: fix missing | operator when setting cfg Colin King @ 2018-04-18 15:20 ` Sylwester Nawrocki 2018-04-18 15:23 ` Sylwester Nawrocki 0 siblings, 1 reply; 5+ messages in thread From: Sylwester Nawrocki @ 2018-04-18 15:20 UTC (permalink / raw) To: Colin King Cc: Kyungmin Park, Mauro Carvalho Chehab, Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel, linux-samsung-soc, kernel-janitors, linux-kernel On 04/18/2018 05:06 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The value from a readl is being masked with ITE_REG_CIOCAN_MASK however > this is not being used and cfg is being re-assigned. I believe the > assignment operator should actually be instead the |= operator. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks for the patch. Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] include/media: fix missing | operator when setting cfg 2018-04-18 15:20 ` Sylwester Nawrocki @ 2018-04-18 15:23 ` Sylwester Nawrocki 2018-04-18 15:24 ` Colin Ian King 0 siblings, 1 reply; 5+ messages in thread From: Sylwester Nawrocki @ 2018-04-18 15:23 UTC (permalink / raw) To: Colin King Cc: Kyungmin Park, Mauro Carvalho Chehab, Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel, linux-samsung-soc, kernel-janitors, linux-kernel On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >> assignment operator should actually be instead the |= operator. >> >> Detected by CoverityScan, CID#1467987 ("Unused value") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > Thanks for the patch. > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> I forgot to mention that the subject should rather looks something like: "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" -- Regards, Sylwester ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] include/media: fix missing | operator when setting cfg 2018-04-18 15:23 ` Sylwester Nawrocki @ 2018-04-18 15:24 ` Colin Ian King 2018-04-18 15:27 ` Sylwester Nawrocki 0 siblings, 1 reply; 5+ messages in thread From: Colin Ian King @ 2018-04-18 15:24 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Kyungmin Park, Mauro Carvalho Chehab, Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel, linux-samsung-soc, kernel-janitors, linux-kernel On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>> this is not being used and cfg is being re-assigned. I believe the >>> assignment operator should actually be instead the |= operator. >>> >>> Detected by CoverityScan, CID#1467987 ("Unused value") >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> Thanks for the patch. >> >> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > I forgot to mention that the subject should rather looks something > like: > > "exynos4-is: fimc-lite: : fix missing | operator when setting cfg" > Oops, shall I re-send? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] include/media: fix missing | operator when setting cfg 2018-04-18 15:24 ` Colin Ian King @ 2018-04-18 15:27 ` Sylwester Nawrocki 0 siblings, 0 replies; 5+ messages in thread From: Sylwester Nawrocki @ 2018-04-18 15:27 UTC (permalink / raw) To: Colin Ian King Cc: Kyungmin Park, Mauro Carvalho Chehab, Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel, linux-samsung-soc, kernel-janitors, linux-kernel On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-18 15:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180418150622epcas4p4be934b89937c0e50a2f236116c02d7cb@epcas4p4.samsung.com>
2018-04-18 15:06 ` [PATCH] [media] include/media: fix missing | operator when setting cfg Colin King
2018-04-18 15:20 ` Sylwester Nawrocki
2018-04-18 15:23 ` Sylwester Nawrocki
2018-04-18 15:24 ` Colin Ian King
2018-04-18 15:27 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®