mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Adrian Ambrozewicz <aambrozewicz@nvidia.com>
Cc: "Donald Shannon" <donalds@nvidia.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Linus Walleij" <linusw@kernel.org>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Corey Minyard" <corey@minyard.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>, "Jonathan Corbet" <corbet@lwn.net>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Lixu Zhang" <lixu.zhang@intel.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Johan Hovold" <johan@kernel.org>,
	"Oliver Neukum" <oneukum@suse.com>,
	"Quan Nguyen" <quan@os.amperecomputing.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-serial@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org,
	driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers
Date: Wed, 14 Oct 2026 11:38:45 +0800	[thread overview]
Message-ID: <c569c912141e9da7530121b8b2fc81527e0518a4.camel@codeconstruct.com.au> (raw)
In-Reply-To: <2026101310-scuttle-unison-d4c3@gregkh>

Hi Adrian & Greg,

> > This series adds drivers for the NVIDIA LSTP USB adapter: a USB core
> > driver and GPIO, LED, I2C, SPI, UART and BMC-side IPMI function drivers,
> > with their device tree bindings, an ACPI description document and the
> > sysfs ABI.

Adrian, what is the plan for this coexisting with the recently-released
OBMF-ICP spec[1], which implements almost identical functionality (and
apparently with less DT/ACPI description requirements)

... NVIDIA also being a primary contributor to OBMF-ICP.

[1]: https://www.opencompute.org/wp-content/uploads/2026/10/obmf-icp-1-0-0.pdf

> > What LSTP is
> > ------------
> > 
> > LSTP (Low-Speed Transport Protocol or Low-Speed Tunnelling Protocol) is
> > a vendor-specific USB interface (class 0xff, subclass 0x3f) that
> > multiplexes several low-speed "channels" over one pair of bulk
> > endpoints. It is implemented by NVIDIA's SMA, an MCU (0955:cf11), and
> > by other vendors' parts: two hub/bridge chips have it built in
> > (0424:4940, 174c:2214). Boards use it to
> > reach SPI flash, I2C sensors, GPIOs and LEDs, a UART and a host-to-BMC
> > IPMI path, on both BMCs and host systems.
> 
> Also, if you really want to do this in a dynamic way, use greybus, as
> that is EXPLICITLY what it was designed for, and is patent-free (i.e.
> unencumbered, and we already support it in the kernel.)  Please don't
> reinvent the wheel/spec just because no one did any prior-art
> research...

With this, we now have three similar facilities:

 - greybus - I assume there are implementations about, but more on the
   mobile side?
 - LSTP - with an NVIDIA implementation
 - OBMF-ICP - with a few vendors' early implementations

There are differences between greybus and OBMF-ICP that may justify
support for both (primarily: static channel support means OBMF-ICP is
simpler to implement). I understand that OBMF-ICP also has reasonable IP
protections for implementations. However, it's going to be difficult to
justify both LSTP and OBMF-ICP implementations living in the kernel.

Adrian: I could see LSTP being implemented as a set of divergences from
an OBMF-ICP-standard driver, but I'm not yet across why you need static
configuration. If we do need support for both in the kernel, I can take
a look at how that could work.

FWIW, we did raise greybus as an approach to various HW vendors; I
assume there were reasons behind OBMF-ICP, and assume some prior-art
assesment was involved, but I don't have specifics for those reasons.

HW peeps: This would be an excellent opportunity for elaboration on the
motivation there, either for LSTP or OBMF-OCP.

Cheers,


Jeremy

  reply	other threads:[~2026-10-14  3:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 17:35 Adrian Ambrozewicz
2026-10-12 17:35 ` [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO Adrian Ambrozewicz
2026-10-13  6:09   ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 02/11] dt-bindings: i2c: Add NVIDIA LSTP I2C Adrian Ambrozewicz
2026-10-13  6:11   ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 03/11] dt-bindings: spi: Add NVIDIA LSTP SPI Adrian Ambrozewicz
2026-10-13  6:11   ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter Adrian Ambrozewicz
2026-10-13  6:13   ` Krzysztof Kozlowski
2026-10-13  6:17   ` Krzysztof Kozlowski
2026-10-12 17:36 ` [PATCH 05/11] usb: misc: Add NVIDIA LSTP USB adapter driver Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 06/11] gpio: Add NVIDIA LSTP GPIO driver Adrian Ambrozewicz
2026-10-13 23:25   ` Linus Walleij
2026-10-12 17:36 ` [PATCH 07/11] leds: Add NVIDIA LSTP LED driver Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 08/11] i2c: Add NVIDIA LSTP I2C driver Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 09/11] spi: Add NVIDIA LSTP SPI driver Adrian Ambrozewicz
2026-10-12 17:36 ` [PATCH 10/11] tty: Add NVIDIA LSTP UART driver Adrian Ambrozewicz
2026-10-13  5:49   ` Jiri Slaby
2026-10-12 17:36 ` [PATCH 11/11] ipmi: Add NVIDIA LSTP IPMI BMC driver Adrian Ambrozewicz
2026-10-12 21:10   ` Corey Minyard
2026-10-13 11:37 ` [PATCH 00/11] Add NVIDIA LSTP USB adapter drivers Greg Kroah-Hartman
2026-10-13 11:39 ` Greg Kroah-Hartman
2026-10-14  3:38   ` Jeremy Kerr [this message]
2026-10-14  4:53     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c569c912141e9da7530121b8b2fc81527e0518a4.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=aambrozewicz@nvidia.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=corey@minyard.net \
    --cc=dakr@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=donalds@nvidia.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    --cc=oneukum@suse.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=pavel@kernel.org \
    --cc=quan@os.amperecomputing.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®