* [PATCH v2 1/4] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz
2025-11-20 5:25 [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Kevin Tung
@ 2025-11-20 5:25 ` Kevin Tung
2025-11-20 5:25 ` [PATCH v2 2/4] ARM: dts: aspeed: yosemite5: Update sensor configuration Kevin Tung
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Kevin Tung @ 2025-11-20 5:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang, Kevin Tung
Configure i2c4 and i2c12 to operate at 400 kHz instead of 100 kHz.
This update aligns the bus settings with the hardware capabilities
and improves MCTP communication performance.
Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 2486981f3d6bd36f3fe780b21e834b85242f8aa9..7991e9360847532cff9aad4ad4ed57d4c30668a0 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -231,6 +231,7 @@ sbtsi@4c {
&i2c4 {
multi-master;
mctp-controller;
+ clock-frequency = <400000>;
status = "okay";
mctp@10 {
@@ -782,6 +783,7 @@ adc@4b {
&i2c12 {
multi-master;
mctp-controller;
+ clock-frequency = <400000>;
status = "okay";
mctp@10 {
--
2.51.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 2/4] ARM: dts: aspeed: yosemite5: Update sensor configuration
2025-11-20 5:25 [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Kevin Tung
2025-11-20 5:25 ` [PATCH v2 1/4] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz Kevin Tung
@ 2025-11-20 5:25 ` Kevin Tung
2025-11-20 5:26 ` [PATCH v2 3/4] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L Kevin Tung
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Kevin Tung @ 2025-11-20 5:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang, Kevin Tung
Remove sensors 10-0040 and 10-0045 to align with the latest
hardware design changes.
Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -674,20 +674,6 @@ gpio-expander@22 {
"PWRGD_P3V3_AUX","ALERT_TEMP";
};
- power-sensor@40 {
- compatible = "ti,ina233";
- reg = <0x40>;
- shunt-resistor = <2000>;
- ti,maximum-expected-current-microamp = <32768000>;
- };
-
- power-sensor@45 {
- compatible = "ti,ina233";
- reg = <0x45>;
- shunt-resistor = <2000>;
- ti,maximum-expected-current-microamp = <32768000>;
- };
-
adc@48 {
compatible = "ti,ads7830";
reg = <0x48>;
--
2.51.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 3/4] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L
2025-11-20 5:25 [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Kevin Tung
2025-11-20 5:25 ` [PATCH v2 1/4] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz Kevin Tung
2025-11-20 5:25 ` [PATCH v2 2/4] ARM: dts: aspeed: yosemite5: Update sensor configuration Kevin Tung
@ 2025-11-20 5:26 ` Kevin Tung
2025-11-20 5:26 ` [PATCH v2 4/4] ARM: dts: aspeed: yosemite5: Add ipmb node for OCP debug card Kevin Tung
2025-11-24 4:53 ` [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Andrew Jeffery
4 siblings, 0 replies; 7+ messages in thread
From: Kevin Tung @ 2025-11-20 5:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang, Kevin Tung
Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.
Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -964,7 +964,7 @@ &sgpiom0 {
"FAULT_P3V3_NIC_N","",
"FAULT_P12V_NIC_N","",
"FAULT_P12V_SCM_N","",
- "P0_I3C_APML_ALERT_L","",
+ "FM_APML_CPU_ALERT_N","",
"ALERT_INLET_TEMP_N","",
"FM_CPU_PROCHOT_R_N","",
"FM_CPU_THERMTRIP_N","",
--
2.51.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 4/4] ARM: dts: aspeed: yosemite5: Add ipmb node for OCP debug card
2025-11-20 5:25 [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Kevin Tung
` (2 preceding siblings ...)
2025-11-20 5:26 ` [PATCH v2 3/4] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L Kevin Tung
@ 2025-11-20 5:26 ` Kevin Tung
2025-11-24 4:53 ` [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Andrew Jeffery
4 siblings, 0 replies; 7+ messages in thread
From: Kevin Tung @ 2025-11-20 5:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang, Kevin Tung
Add the device tree node to enable the IPMB interface used by
the OCP debug card.
Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 060757b7211a6da777c51d9f0c886796cf2450a4..b4ae1628ad5a8f8b5283f88760877846862b3835 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -365,7 +365,14 @@ i2c6mux0ch3: i2c@3 {
/* SCM CPLD I2C */
&i2c7 {
+ multi-master;
status = "okay";
+
+ ipmb@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
};
&i2c8 {
--
2.51.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/4] Revise Meta Yosemite5 devicetree
2025-11-20 5:25 [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Kevin Tung
` (3 preceding siblings ...)
2025-11-20 5:26 ` [PATCH v2 4/4] ARM: dts: aspeed: yosemite5: Add ipmb node for OCP debug card Kevin Tung
@ 2025-11-24 4:53 ` Andrew Jeffery
2025-12-19 8:39 ` Kevin Tung
4 siblings, 1 reply; 7+ messages in thread
From: Andrew Jeffery @ 2025-11-24 4:53 UTC (permalink / raw)
To: Kevin Tung, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang
Hi Kevin,
On Thu, 2025-11-20 at 13:25 +0800, Kevin Tung wrote:
> Summary:
> Revise linux device tree entry related to Meta (Facebook) Yosemite5.
>
> Changes in v2:
> - Add ipmb node for OCP debug card
> - Link to v1: https://lore.kernel.org/r/20251118-yv5_revise_dts-v1-0-fcd6b44b4497@gmail.com
>
> Changes in v1:
> - Increase i2c4/i2c12 bus speed to 400 kHz
> - Update sensor configuration
> - Rename sgpio P0_I3C_APML_ALERT_L
Sorry, I replied with comments on v1 before I saw v2.
Can you please resolve the discussions on v1 and send a follow-up
series if necessary?
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/4] Revise Meta Yosemite5 devicetree
2025-11-24 4:53 ` [PATCH v2 0/4] Revise Meta Yosemite5 devicetree Andrew Jeffery
@ 2025-12-19 8:39 ` Kevin Tung
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Tung @ 2025-12-19 8:39 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Amithash Prasasd, Kevin Tung, Ken Chen, Leo Yang
Hi Andrew,
Sorry for the late reply. I’ve addressed the points raised in your review
and sent a follow up v3 patch series. Thanks.
BR,
Kevin
On Mon, Nov 24, 2025 at 12:53 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> Hi Kevin,
>
> On Thu, 2025-11-20 at 13:25 +0800, Kevin Tung wrote:
> > Summary:
> > Revise linux device tree entry related to Meta (Facebook) Yosemite5.
> >
> > Changes in v2:
> > - Add ipmb node for OCP debug card
> > - Link to v1: https://lore.kernel.org/r/20251118-yv5_revise_dts-v1-0-fcd6b44b4497@gmail.com
> >
> > Changes in v1:
> > - Increase i2c4/i2c12 bus speed to 400 kHz
> > - Update sensor configuration
> > - Rename sgpio P0_I3C_APML_ALERT_L
>
> Sorry, I replied with comments on v1 before I saw v2.
>
> Can you please resolve the discussions on v1 and send a follow-up
> series if necessary?
>
> Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread