* [PATCH ath-next 1/2] wifi: ath12k: Correctly copy the hint BSSID in WMI scan request
2026-07-13 16:15 [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request Jeff Johnson
@ 2026-07-13 16:15 ` Jeff Johnson
2026-07-13 16:15 ` [PATCH ath-next 2/2] wifi: ath11k: " Jeff Johnson
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2026-07-13 16:15 UTC (permalink / raw)
To: Jeff Johnson
Cc: linux-wireless, ath11k, ath12k, linux-kernel, Baochen Qiang,
Jeff Johnson
Currently, in ath12k_wmi_send_scan_start_cmd(), the logic to populate
the hint_bssid copies the BSSID in the wrong direction, from the
firmware message to the argument buffer. Swap the parameters so that
the BSSID is correctly populated in the firmware message from the
argument buffer.
Compile tested only.
Reported-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Closes: https://lore.kernel.org/linux-wireless/afbff608-a005-43c4-af76-968a58bf0cc3@oss.qualcomm.com/
Fixes: f40abb4788a2 ("ath12k: New driver for Qualcomm 11be hw family")
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
index ad739bffcf88..fe9394d561f1 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.c
+++ b/drivers/net/wireless/ath/ath12k/wmi.c
@@ -2796,8 +2796,8 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar,
for (i = 0; i < arg->num_hint_bssid; ++i) {
hint_bssid->freq_flags =
arg->hint_bssid[i].freq_flags;
- ether_addr_copy(&arg->hint_bssid[i].bssid.addr[0],
- &hint_bssid->bssid.addr[0]);
+ ether_addr_copy(&hint_bssid->bssid.addr[0],
+ &arg->hint_bssid[i].bssid.addr[0]);
hint_bssid++;
}
}
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH ath-next 2/2] wifi: ath11k: Correctly copy the hint BSSID in WMI scan request
2026-07-13 16:15 [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request Jeff Johnson
2026-07-13 16:15 ` [PATCH ath-next 1/2] wifi: ath12k: " Jeff Johnson
@ 2026-07-13 16:15 ` Jeff Johnson
2026-07-14 2:43 ` [PATCH ath-next 0/2] wifi: ath: " Baochen Qiang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2026-07-13 16:15 UTC (permalink / raw)
To: Jeff Johnson
Cc: linux-wireless, ath11k, ath12k, linux-kernel, Baochen Qiang,
Jeff Johnson
Currently, in ath11k_wmi_send_scan_start_cmd(), the logic to populate
the hint_bssid copies the BSSID in the wrong direction, from the
firmware message to the argument buffer. Swap the parameters so that
the BSSID is correctly populated in the firmware message from the
argument buffer.
This issue was reported on ath12k, but exists in ath11k as well.
Compile tested only.
Reported-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Closes: https://lore.kernel.org/linux-wireless/afbff608-a005-43c4-af76-968a58bf0cc3@oss.qualcomm.com/
Fixes: 74601ecfef6e ("ath11k: Add support for 6g scan hint")
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath11k/wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index dca6e011cc40..c54f50b98a13 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -2423,8 +2423,8 @@ int ath11k_wmi_send_scan_start_cmd(struct ath11k *ar,
for (i = 0; i < params->num_hint_bssid; ++i) {
hint_bssid->freq_flags =
params->hint_bssid[i].freq_flags;
- ether_addr_copy(¶ms->hint_bssid[i].bssid.addr[0],
- &hint_bssid->bssid.addr[0]);
+ ether_addr_copy(&hint_bssid->bssid.addr[0],
+ ¶ms->hint_bssid[i].bssid.addr[0]);
hint_bssid++;
}
}
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request
2026-07-13 16:15 [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request Jeff Johnson
2026-07-13 16:15 ` [PATCH ath-next 1/2] wifi: ath12k: " Jeff Johnson
2026-07-13 16:15 ` [PATCH ath-next 2/2] wifi: ath11k: " Jeff Johnson
@ 2026-07-14 2:43 ` Baochen Qiang
2026-07-14 16:57 ` Rameshkumar Sundaram
2026-07-17 15:06 ` Jeff Johnson
4 siblings, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2026-07-14 2:43 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath11k, ath12k, linux-kernel
On 7/14/2026 12:15 AM, Jeff Johnson wrote:
> Issue was reported in ath12k, but exists in ath11k as well.
>
> ---
> Jeff Johnson (2):
> wifi: ath12k: Correctly copy the hint BSSID in WMI scan request
> wifi: ath11k: Correctly copy the hint BSSID in WMI scan request
>
> drivers/net/wireless/ath/ath11k/wmi.c | 4 ++--
> drivers/net/wireless/ath/ath12k/wmi.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: fa1b1469f1c5f0f54ed9dab80106a117e7736bfd
> change-id: 20260712-ath12k_wmi_send_scan_start_cmd-bad-hint_bssid-8786dbd8cff9
>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request
2026-07-13 16:15 [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request Jeff Johnson
` (2 preceding siblings ...)
2026-07-14 2:43 ` [PATCH ath-next 0/2] wifi: ath: " Baochen Qiang
@ 2026-07-14 16:57 ` Rameshkumar Sundaram
2026-07-17 15:06 ` Jeff Johnson
4 siblings, 0 replies; 6+ messages in thread
From: Rameshkumar Sundaram @ 2026-07-14 16:57 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson
Cc: linux-wireless, ath11k, ath12k, linux-kernel, Baochen Qiang
On 7/13/2026 9:45 PM, Jeff Johnson wrote:
> Issue was reported in ath12k, but exists in ath11k as well.
>
> ---
> Jeff Johnson (2):
> wifi: ath12k: Correctly copy the hint BSSID in WMI scan request
> wifi: ath11k: Correctly copy the hint BSSID in WMI scan request
>
> drivers/net/wireless/ath/ath11k/wmi.c | 4 ++--
> drivers/net/wireless/ath/ath12k/wmi.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: fa1b1469f1c5f0f54ed9dab80106a117e7736bfd
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request
2026-07-13 16:15 [PATCH ath-next 0/2] wifi: ath: Correctly copy the hint BSSID in WMI scan request Jeff Johnson
` (3 preceding siblings ...)
2026-07-14 16:57 ` Rameshkumar Sundaram
@ 2026-07-17 15:06 ` Jeff Johnson
4 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2026-07-17 15:06 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson
Cc: linux-wireless, ath11k, ath12k, linux-kernel, Baochen Qiang
On Mon, 13 Jul 2026 09:15:48 -0700, Jeff Johnson wrote:
> Issue was reported in ath12k, but exists in ath11k as well.
>
Applied, thanks!
[1/2] wifi: ath12k: Correctly copy the hint BSSID in WMI scan request
commit: b127f79a49335679d117406257cedab4fc20596a
[2/2] wifi: ath11k: Correctly copy the hint BSSID in WMI scan request
commit: 0db9d58c8757d0be5ed546109e37bcb10f6c1fb6
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread