mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kvm list <kvm@vger.kernel.org>,
	Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [RFC/RFT PATCH] KVM: nVMX: fixes to nested virt interrupt injection
Date: Wed, 26 Jul 2017 17:23:38 +0200	[thread overview]
Message-ID: <c57ea9ad-f0bd-0184-fa81-0bc3c2c08f0a@redhat.com> (raw)
In-Reply-To: <CALMp9eTm9bsgZhFTKAA0BDFPiFiAyMoF6HRYqhJB8aRWkKQsKQ@mail.gmail.com>

On 26/07/2017 16:55, Jim Mattson wrote:
> Hmmm.  That field isn't writable on all microarchitectures.

You're right... I'll see if there's a simple workaround, or it requires
to rework reflection of EXCEPTION_NMI vmexits.  The latter would fix
PFEC_MASK/MATCH, too...

Paolo

> On Wed, Jul 26, 2017 at 7:48 AM, Paolo Bonzini <pbonzini@redhat.com
> <mailto:pbonzini@redhat.com>> wrote:
> 
>     On 25/07/2017 23:08, Jim Mattson wrote:
>     >
>     >     +
>     >     +       if (vcpu->arch.exception.has_error_code) {
>     >     +               vmcs_write32(VM_EXIT_INTR_ERROR_CODE,
>     >     vcpu->arch.exception.error_code);
>     >
>     >
>     > Should this be vmcs12->vm_exit_intr_error_code
>     > = vcpu->arch.exception.error_code?
> 
>     No, this writes to the vmcs02 and prepare_vmcs12 copies it to the
>     vmcs12.
> 
>     Paolo
> 
> 

  parent reply	other threads:[~2017-07-26 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 14:20 Paolo Bonzini
2017-07-24 14:44 ` Wanpeng Li
2017-07-24 14:44   ` Paolo Bonzini
2017-07-24 14:46     ` Wanpeng Li
     [not found] ` <CALMp9eT4Ubm07om72vJhjWT5K7f1-D1oionGLB6uxcQ3XmPTUQ@mail.gmail.com>
2017-07-26 14:48   ` Paolo Bonzini
     [not found]     ` <CALMp9eTm9bsgZhFTKAA0BDFPiFiAyMoF6HRYqhJB8aRWkKQsKQ@mail.gmail.com>
2017-07-26 15:23       ` Paolo Bonzini [this message]
2017-07-27  2:45 ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c57ea9ad-f0bd-0184-fa81-0bc3c2c08f0a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®