From: Thierry Escande <thierry.escande@collabora.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files
Date: Tue, 11 Apr 2017 16:28:45 +0200 [thread overview]
Message-ID: <c58eb125-db5d-0553-6ffe-a4697000f58c@collabora.com> (raw)
In-Reply-To: <20170411140919.GC4388@kroah.com>
Hi Greg
On 11/04/2017 16:09, Greg Kroah-Hartman wrote:
> On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote:
>> +#include <linux/export.h>
>> +
>> +#include "vpd_decode.h"
>> +
>> +static int decode_len(const int32_t max_len, const uint8_t *in,
>> + int32_t *length, int32_t *decoded_len)
>> +{
>> + uint8_t more;
>
> Care to use "real" kernel variable types please? u8, u16, and others
> are you friend, uint8_t really isn't what we prefer, and checkpatch
> should tell you that...
By default checkpatch doesn't warn about types unless --strict is
specified... Sorry about that.
Regards,
Thierry
next prev parent reply other threads:[~2017-04-11 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 9:14 [PATCH 0/2] Google VPD sysfs driver Thierry Escande
2017-04-11 9:14 ` [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande
2017-04-11 14:09 ` Greg Kroah-Hartman
2017-04-11 14:28 ` Thierry Escande [this message]
2017-04-11 18:15 ` Joe Perches
2017-04-11 18:42 ` Greg Kroah-Hartman
2017-04-11 18:50 ` Joe Perches
2017-04-11 14:10 ` Greg Kroah-Hartman
2017-04-11 14:11 ` Greg Kroah-Hartman
2017-04-11 14:31 ` Thierry Escande
2017-04-11 9:14 ` [PATCH 2/2] firmware: Google VPD sysfs driver Thierry Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58eb125-db5d-0553-6ffe-a4697000f58c@collabora.com \
--to=thierry.escande@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®