* [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel Gerald Loacker
@ 2024-05-29 14:42 ` Gerald Loacker
2024-05-29 14:42 ` [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak " Gerald Loacker
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Gerald Loacker @ 2024-05-29 14:42 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, Gerald Loacker
Flickering was observed when using partial mode. Moving the vsync to the
same position as used by the default sitronix-st7789v timing resolves this
issue.
Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
---
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index 88e80fe98112..32e5c0348038 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -286,9 +286,9 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
.hsync_end = 240 + 28 + 10,
.htotal = 240 + 28 + 10 + 10,
.vdisplay = 280,
- .vsync_start = 280 + 8,
- .vsync_end = 280 + 8 + 4,
- .vtotal = 280 + 8 + 4 + 4,
+ .vsync_start = 280 + 48,
+ .vsync_end = 280 + 48 + 4,
+ .vtotal = 280 + 48 + 4 + 4,
.width_mm = 43,
.height_mm = 37,
.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
--
2.37.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak timing for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel Gerald Loacker
2024-05-29 14:42 ` [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix timing " Gerald Loacker
@ 2024-05-29 14:42 ` Gerald Loacker
2024-05-29 20:20 ` Jessica Zhang
2024-05-29 14:42 ` [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size " Gerald Loacker
2024-05-30 13:02 ` [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes " Neil Armstrong
3 siblings, 1 reply; 7+ messages in thread
From: Gerald Loacker @ 2024-05-29 14:42 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, Gerald Loacker
Use the default timing parameters to get a refresh rate of about 60 Hz for
a clock of 6 MHz.
Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
---
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index 32e5c0348038..c7e3f1280404 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -282,9 +282,9 @@ static const struct drm_display_mode et028013dma_mode = {
static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
.clock = 6000,
.hdisplay = 240,
- .hsync_start = 240 + 28,
- .hsync_end = 240 + 28 + 10,
- .htotal = 240 + 28 + 10 + 10,
+ .hsync_start = 240 + 38,
+ .hsync_end = 240 + 38 + 10,
+ .htotal = 240 + 38 + 10 + 10,
.vdisplay = 280,
.vsync_start = 280 + 48,
.vsync_end = 280 + 48 + 4,
--
2.37.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak timing for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 ` [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak " Gerald Loacker
@ 2024-05-29 20:20 ` Jessica Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Jessica Zhang @ 2024-05-29 20:20 UTC (permalink / raw)
To: Gerald Loacker, Neil Armstrong, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel
On 5/29/2024 7:42 AM, Gerald Loacker wrote:
> Use the default timing parameters to get a refresh rate of about 60 Hz for
> a clock of 6 MHz.
>
> Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Hi Gerald,
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index 32e5c0348038..c7e3f1280404 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -282,9 +282,9 @@ static const struct drm_display_mode et028013dma_mode = {
> static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
> .clock = 6000,
> .hdisplay = 240,
> - .hsync_start = 240 + 28,
> - .hsync_end = 240 + 28 + 10,
> - .htotal = 240 + 28 + 10 + 10,
> + .hsync_start = 240 + 38,
> + .hsync_end = 240 + 38 + 10,
> + .htotal = 240 + 38 + 10 + 10,
> .vdisplay = 280,
> .vsync_start = 280 + 48,
> .vsync_end = 280 + 48 + 4,
>
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel Gerald Loacker
2024-05-29 14:42 ` [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix timing " Gerald Loacker
2024-05-29 14:42 ` [PATCH v2 2/3] drm/panel: sitronix-st7789v: tweak " Gerald Loacker
@ 2024-05-29 14:42 ` Gerald Loacker
2024-05-29 20:24 ` Jessica Zhang
2024-05-30 13:02 ` [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes " Neil Armstrong
3 siblings, 1 reply; 7+ messages in thread
From: Gerald Loacker @ 2024-05-29 14:42 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, Gerald Loacker
This is a portrait mode display. Change the dimensions accordingly.
Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
---
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index c7e3f1280404..e8f385b9c618 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -289,8 +289,8 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
.vsync_start = 280 + 48,
.vsync_end = 280 + 48 + 4,
.vtotal = 280 + 48 + 4 + 4,
- .width_mm = 43,
- .height_mm = 37,
+ .width_mm = 37,
+ .height_mm = 43,
.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
};
--
2.37.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 ` [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size " Gerald Loacker
@ 2024-05-29 20:24 ` Jessica Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Jessica Zhang @ 2024-05-29 20:24 UTC (permalink / raw)
To: Gerald Loacker, Neil Armstrong, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel
On 5/29/2024 7:42 AM, Gerald Loacker wrote:
> This is a portrait mode display. Change the dimensions accordingly.
>
> Fixes: 0fbbe96bfa08 ("drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support")
> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index c7e3f1280404..e8f385b9c618 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -289,8 +289,8 @@ static const struct drm_display_mode jt240mhqs_hwt_ek_e3_mode = {
> .vsync_start = 280 + 48,
> .vsync_end = 280 + 48 + 4,
> .vtotal = 280 + 48 + 4 + 4,
> - .width_mm = 43,
> - .height_mm = 37,
> + .width_mm = 37,
> + .height_mm = 43,
> .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> };
>
>
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel
2024-05-29 14:42 [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel Gerald Loacker
` (2 preceding siblings ...)
2024-05-29 14:42 ` [PATCH v2 3/3] drm/panel: sitronix-st7789v: fix display size " Gerald Loacker
@ 2024-05-30 13:02 ` Neil Armstrong
3 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2024-05-30 13:02 UTC (permalink / raw)
To: Jessica Zhang, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Gerald Loacker
Cc: dri-devel, linux-kernel
Hi,
On Wed, 29 May 2024 16:42:44 +0200, Gerald Loacker wrote:
> At the jt240mhqs_hwt_ek_e3 panel, noticeable flickering occurs. This is
> addressed by patch 1, which adjusts the vertical timing. Patch 2 and 3 are
> two more minor fixes for timing and dimension.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek_e3 panel
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/0e5895ff7fab0fc05ec17daf9a568368828fa6ea
[2/3] drm/panel: sitronix-st7789v: tweak timing for jt240mhqs_hwt_ek_e3 panel
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/2ba50582634d0bfe3a333ab7575a7f0122a7cde8
[3/3] drm/panel: sitronix-st7789v: fix display size for jt240mhqs_hwt_ek_e3 panel
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/b62c150c3bae72ac1910dcc588f360159eb0744a
--
Neil
^ permalink raw reply [flat|nested] 7+ messages in thread