From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@kernel.org, seiden@linux.ibm.com,
nrb@linux.ibm.com, schlameuss@linux.ibm.com, gra@linux.ibm.com
Subject: Re: [PATCH v3 3/5] KVM: s390: vsie: Fix unshadowing logic
Date: Tue, 19 May 2026 18:06:44 +0200 [thread overview]
Message-ID: <c5c733b0-601d-4b79-9bc9-3db8cb050845@de.ibm.com> (raw)
In-Reply-To: <20260519150114.264309-4-imbrenda@linux.ibm.com>
Am 19.05.26 um 17:01 schrieb Claudio Imbrenda:
> In some cases (i.e. under extreme memory pressure on the host),
> attempting to shadow memory will result in the same memory being
> unshadowed, causing a loop.
>
> Add a PGSTE bit to distinguish between shadowed memory and shadowed DAT
> tables, fix the unshadowing logic in _gmap_ptep_xchg() to prevent
> unnecessary unshadowing and perform better checks.
>
> Also fix the unshadowing logic in _gmap_crstep_xchg_atomic() which did
> not unshadow properly when the large page would become unprotected.
>
> Opportunistically add a check in gmap_protect_rmap() to make sure it
> won't be called with level == TABLE_TYPE_PAGE_TABLE.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Fixes: a2c17f9270cc ("KVM: s390: New gmap code")
Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
next prev parent reply other threads:[~2026-05-19 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 15:01 [PATCH v3 0/5] KVM: s390: some vSIE and UCONTROL fixes Claudio Imbrenda
2026-05-19 15:01 ` [PATCH v3 1/5] KVM: s390: vsie: Fix memory leak when unshadowing Claudio Imbrenda
2026-05-19 15:01 ` [PATCH v3 2/5] KVM: s390: Fix leaking kvm_s390_mmu_cache in case of errors Claudio Imbrenda
2026-05-19 15:01 ` [PATCH v3 3/5] KVM: s390: vsie: Fix unshadowing logic Claudio Imbrenda
2026-05-19 16:06 ` Christian Borntraeger [this message]
2026-05-19 15:01 ` [PATCH v3 4/5] KVM: s390: vsie: Fix redundant rmap entries Claudio Imbrenda
2026-05-19 15:01 ` [PATCH v3 5/5] KVM: s390: Properly reset zero bit in PGSTE Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c733b0-601d-4b79-9bc9-3db8cb050845@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=gra@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
--cc=seiden@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®