From: Mark Brown <broonie@kernel.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: Russ Weight <russell.h.weight@intel.com>,
gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, matthew.gerlach@linux.intel.com,
Jim Wylder <jwylder@google.com>
Subject: Re: [PATCH 1/1] regmap: spi-avmm: Fix regmap_bus max_raw_write
Date: Mon, 26 Jun 2023 20:47:27 +0100 [thread overview]
Message-ID: <c5c95368-eac3-4250-b50a-50f0a526b753@sirena.org.uk> (raw)
In-Reply-To: <ZJfB9zXhizbqmIrm@yilunxu-OptiPlex-7050>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Sun, Jun 25, 2023 at 12:26:31PM +0800, Xu Yilun wrote:
> IIUC, max_raw_write/read is the max batch *DATA* size that could be
> handled by the receiver. reg addr bytes are not counted in. I'm not 100%
> sure this is obeyed by all drivers. But see several examples:
There's clearly been some confusion in a bunch of drivers, those you've
identified below need fixing too for the new code from the looks of it.
I'm frankly unclear why some of the drivers you're pointing at are even
implementing raw buses.
> So I'm not sure if commit 3981514180c9 is actually necessary.
That's "regmap: Account for register length when chunking". It's
certainly a bit unclear now I go do another survey, though it's also
clear that things like the handling of padding are intermittent at best.
We probably would be safe reverting that.
Jim, where were you seeing the issue here?
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-26 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 20:28 Russ Weight
2023-06-20 21:22 ` Russ Weight
2023-06-20 22:03 ` Mark Brown
2023-06-25 4:26 ` Xu Yilun
2023-06-26 19:47 ` Mark Brown [this message]
2023-06-26 20:23 ` Jim Wylder
2023-06-27 3:36 ` Xu Yilun
2023-06-27 11:58 ` Mark Brown
2023-06-27 12:48 ` Jim Wylder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c95368-eac3-4250-b50a-50f0a526b753@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwylder@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®