From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version
Date: Wed, 30 Apr 2025 08:15:27 +0200 [thread overview]
Message-ID: <c611add2-bb79-4cdb-a612-0f47d427c905@linaro.org> (raw)
In-Reply-To: <000934a5-4934-4d21-8859-897fe48474dc@linaro.org>
On 29/04/2025 21:40, Bryan O'Donoghue wrote:
> On 29/04/2025 19:08, Krzysztof Kozlowski wrote:
>> - dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
>> - vfe->id, gen, rev, step);
>
> Please just change to dev_dbg_once() instead of entirely removing.
Why?
This is entirely useless message, isn't it? Version is deducible from
the compatible.
>
> Same comment with the other patches.
>
> ---
> bod
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-30 6:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 18:08 Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 2/3] media: qcom: camss: csid: " Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 3/3] media: qcom: camss: csiphy: " Krzysztof Kozlowski
2025-04-29 18:11 ` [PATCH 1/3] media: qcom: camss: vfe: " Krzysztof Kozlowski
2025-04-29 19:40 ` Bryan O'Donoghue
2025-04-30 6:15 ` Krzysztof Kozlowski [this message]
2025-04-30 7:25 ` Johan Hovold
2025-04-30 8:19 ` Krzysztof Kozlowski
2025-04-30 8:30 ` Bryan O'Donoghue
2025-04-30 8:33 ` Krzysztof Kozlowski
2025-05-20 6:06 ` Krzysztof Kozlowski
2025-05-20 7:53 ` Johan Hovold
2025-05-20 8:02 ` Krzysztof Kozlowski
2025-05-20 8:23 ` Johan Hovold
2025-05-20 8:30 ` Krzysztof Kozlowski
2025-05-20 8:39 ` Johan Hovold
2025-05-20 8:44 ` Bryan O'Donoghue
2025-05-20 8:51 ` Krzysztof Kozlowski
2025-05-20 8:58 ` Bryan O'Donoghue
2025-05-20 9:16 ` Krzysztof Kozlowski
2025-05-20 9:17 ` Johan Hovold
2025-04-30 12:31 ` Johan Hovold
2025-04-30 8:24 ` Bryan O'Donoghue
2025-04-30 12:34 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c611add2-bb79-4cdb-a612-0f47d427c905@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®