mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Johan Hovold <johan@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version
Date: Tue, 20 May 2025 08:06:22 +0200	[thread overview]
Message-ID: <ea9f570c-b135-4a98-91ea-ceeb2f48a0e5@linaro.org> (raw)
In-Reply-To: <883eb54a-fcaf-443c-a4d7-e1278fd43f5a@linaro.org>

On 30/04/2025 10:33, Krzysztof Kozlowski wrote:
> On 30/04/2025 10:30, Bryan O'Donoghue wrote:
>> On 30/04/2025 09:19, Krzysztof Kozlowski wrote:
>>> If anyone wants to know it and cannot deduce from compatible, then add
>>> debugfs interface.
>>
>> dev_dbg(); isn't too offensive really IMO but if it really bothers you 
>> switching to debugfs would be fine.
> 
> Yes, please. Dmesg should be only contain issues or some useful
> debugging data. Probe success is not useful. It duplicates sysfs and
> tracing. Version of hardware - well, I am sure it duplicates the compatible.

To recall: kernel coding style is also clear here:
"When drivers are working properly they are quiet,"
and kernel debugging guide as well:
"In almost all cases the debug statements shouldn't be upstreamed, as a
working driver is supposed to be silent."

So I really do not get why this driver deserved exception. Nevertheless
I think we agreed that these logs can go away, thus I just sent a v2
with a bit extended commit msg.

Best regards,
Krzysztof

  reply	other threads:[~2025-05-20  6:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 18:08 Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 2/3] media: qcom: camss: csid: " Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 3/3] media: qcom: camss: csiphy: " Krzysztof Kozlowski
2025-04-29 18:11 ` [PATCH 1/3] media: qcom: camss: vfe: " Krzysztof Kozlowski
2025-04-29 19:40 ` Bryan O'Donoghue
2025-04-30  6:15   ` Krzysztof Kozlowski
2025-04-30  7:25 ` Johan Hovold
2025-04-30  8:19   ` Krzysztof Kozlowski
2025-04-30  8:30     ` Bryan O'Donoghue
2025-04-30  8:33       ` Krzysztof Kozlowski
2025-05-20  6:06         ` Krzysztof Kozlowski [this message]
2025-05-20  7:53           ` Johan Hovold
2025-05-20  8:02             ` Krzysztof Kozlowski
2025-05-20  8:23               ` Johan Hovold
2025-05-20  8:30                 ` Krzysztof Kozlowski
2025-05-20  8:39                   ` Johan Hovold
2025-05-20  8:44                   ` Bryan O'Donoghue
2025-05-20  8:51                     ` Krzysztof Kozlowski
2025-05-20  8:58                       ` Bryan O'Donoghue
2025-05-20  9:16                         ` Krzysztof Kozlowski
2025-05-20  9:17                       ` Johan Hovold
2025-04-30 12:31     ` Johan Hovold
2025-04-30  8:24   ` Bryan O'Donoghue
2025-04-30 12:34     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea9f570c-b135-4a98-91ea-ceeb2f48a0e5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®