mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Amjad Ouled-Ameur" <aouledameur@baylibre.com>,
	"Alexandre Mergnat" <amergnat@baylibre.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>
Cc: Fabien Parent <fparent@baylibre.com>,
	Julien Stephan <jstephan@baylibre.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8365: fix infracfg_nao node
Date: Mon, 2 Feb 2026 11:09:47 -0600	[thread overview]
Message-ID: <c616cc63-35fb-49a5-bd1a-ac559574c32d@baylibre.com> (raw)
In-Reply-To: <20251216-mtk-fix-infracfg_nao-compatibile-v1-1-d339b151ac81@baylibre.com>

On 12/16/25 4:57 PM, David Lechner wrote:
> Use correct compatible string for the infracfg_nao: node and remove
> the #clock-cells property.
> 
> Likely this was copied from the similar infracfg: node. However,
> infracfg_nao: is just a syscon node with it's own register definitions
> and is not a clock provider.
> 
> Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8365.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index a5ca3cda6ef3..4116f96c81a9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -537,9 +537,8 @@ iommu: iommu@10205000 {
>  		};
>  
>  		infracfg_nao: infracfg@1020e000 {
> -			compatible = "mediatek,mt8365-infracfg", "syscon";
> +			compatible = "mediatek,mt8365-infracfg-nao", "syscon";
>  			reg = <0 0x1020e000 0 0x1000>;
> -			#clock-cells = <1>;
>  		};
>  
>  		rng: rng@1020f000 {
> 
> ---
> base-commit: 6987d58a9cbc5bd57c983baa514474a86c945d56
> change-id: 20251216-mtk-fix-infracfg_nao-compatibile-ba543769f5b9
> 
> Best regards,

Hmm... it looks like someone sent the same patch (actually better
because they fixed the node name too) quite a while ago [1], but that
patch didn't get picked up either. So I suggest to drop this patch
in favor of that one.

[1]: https://lore.kernel.org/linux-mediatek/20250502-mt8365-infracfg-nao-compatible-v1-2-e40394573f98@collabora.com/



      reply	other threads:[~2026-02-02 17:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 22:57 David Lechner
2026-02-02 17:09 ` David Lechner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c616cc63-35fb-49a5-bd1a-ac559574c32d@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=aouledameur@baylibre.com \
    --cc=bero@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fparent@baylibre.com \
    --cc=jstephan@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®