mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt8365: fix infracfg_nao node
@ 2025-12-16 22:57 David Lechner
  2026-02-02 17:09 ` David Lechner
  0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2025-12-16 22:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Amjad Ouled-Ameur, Alexandre Mergnat,
	Bernhard Rosenkränzer
  Cc: Fabien Parent, Julien Stephan, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, David Lechner

Use correct compatible string for the infracfg_nao: node and remove
the #clock-cells property.

Likely this was copied from the similar infracfg: node. However,
infracfg_nao: is just a syscon node with it's own register definitions
and is not a clock provider.

Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 arch/arm64/boot/dts/mediatek/mt8365.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
index a5ca3cda6ef3..4116f96c81a9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
@@ -537,9 +537,8 @@ iommu: iommu@10205000 {
 		};
 
 		infracfg_nao: infracfg@1020e000 {
-			compatible = "mediatek,mt8365-infracfg", "syscon";
+			compatible = "mediatek,mt8365-infracfg-nao", "syscon";
 			reg = <0 0x1020e000 0 0x1000>;
-			#clock-cells = <1>;
 		};
 
 		rng: rng@1020f000 {

---
base-commit: 6987d58a9cbc5bd57c983baa514474a86c945d56
change-id: 20251216-mtk-fix-infracfg_nao-compatibile-ba543769f5b9

Best regards,
-- 
David Lechner <dlechner@baylibre.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8365: fix infracfg_nao node
  2025-12-16 22:57 [PATCH] arm64: dts: mediatek: mt8365: fix infracfg_nao node David Lechner
@ 2026-02-02 17:09 ` David Lechner
  0 siblings, 0 replies; 2+ messages in thread
From: David Lechner @ 2026-02-02 17:09 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Amjad Ouled-Ameur, Alexandre Mergnat,
	Bernhard Rosenkränzer
  Cc: Fabien Parent, Julien Stephan, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek

On 12/16/25 4:57 PM, David Lechner wrote:
> Use correct compatible string for the infracfg_nao: node and remove
> the #clock-cells property.
> 
> Likely this was copied from the similar infracfg: node. However,
> infracfg_nao: is just a syscon node with it's own register definitions
> and is not a clock provider.
> 
> Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8365.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index a5ca3cda6ef3..4116f96c81a9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -537,9 +537,8 @@ iommu: iommu@10205000 {
>  		};
>  
>  		infracfg_nao: infracfg@1020e000 {
> -			compatible = "mediatek,mt8365-infracfg", "syscon";
> +			compatible = "mediatek,mt8365-infracfg-nao", "syscon";
>  			reg = <0 0x1020e000 0 0x1000>;
> -			#clock-cells = <1>;
>  		};
>  
>  		rng: rng@1020f000 {
> 
> ---
> base-commit: 6987d58a9cbc5bd57c983baa514474a86c945d56
> change-id: 20251216-mtk-fix-infracfg_nao-compatibile-ba543769f5b9
> 
> Best regards,

Hmm... it looks like someone sent the same patch (actually better
because they fixed the node name too) quite a while ago [1], but that
patch didn't get picked up either. So I suggest to drop this patch
in favor of that one.

[1]: https://lore.kernel.org/linux-mediatek/20250502-mt8365-infracfg-nao-compatible-v1-2-e40394573f98@collabora.com/



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-02 17:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-16 22:57 [PATCH] arm64: dts: mediatek: mt8365: fix infracfg_nao node David Lechner
2026-02-02 17:09 ` David Lechner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®