mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jakob Koschel <jkl820.git@gmail.com>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] w1: Replace usage of found with dedicated list iterator variable
Date: Fri, 12 May 2023 09:27:33 +0200	[thread overview]
Message-ID: <c626e464-64e2-3cdb-7cf3-c76770feb1f0@linaro.org> (raw)
In-Reply-To: <20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com>

On 10/05/2023 00:49, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jkl820.git@gmail.com>
> ---
> Changes in v2:
>   - fix checkpatch intentation issues

I don't see the differences and checkpatch still complains. Are you sure
you sent v2?

Best regards,
Krzysztof


  reply	other threads:[~2023-05-12  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 22:49 Jakob Koschel
2023-05-12  7:27 ` Krzysztof Kozlowski [this message]
2023-05-12 10:19   ` Jakob Koschel
2023-05-12 10:26     ` Krzysztof Kozlowski
2023-05-12 11:17       ` Jakob Koschel
2023-05-12 11:23         ` Krzysztof Kozlowski
2023-05-12 11:28           ` Jakob Koschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c626e464-64e2-3cdb-7cf3-c76770feb1f0@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=jkl820.git@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®