From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jakob Koschel <jkl820.git@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Evgeniy Polyakov <zbr@ioremap.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] w1: Replace usage of found with dedicated list iterator variable
Date: Fri, 12 May 2023 12:26:19 +0200 [thread overview]
Message-ID: <12a57688-6e9a-a21d-41cb-978a274c8b2b@kernel.org> (raw)
In-Reply-To: <xxs6zv5j7s6zmko5b5idhynzotx4nnyjktj35sdvelr6ha4aeh@w52ylfmwguva>
On 12/05/2023 12:19, Jakob Koschel wrote:
> How strange, I just checked and my checkpatch doesn't complain.
>
> I also redownloaded and double checked
> (b4 am 20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com).
>
> What's the exact issue you are seeing?
✓ [PATCH v2] w1: Replace usage of found with dedicated list iterator
variable
+ Link:
https://lore.kernel.org/r/20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com
+ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
✗ No key: ed25519/jkl820.git@gmail.com
✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
Base: using specified base-commit eeac8ede17557680855031c6f305ece2378af326
Applying: w1: Replace usage of found with dedicated list iterator variable
[Checking commit] 12b61e664c29 w1: Replace usage of found with
dedicated list iterator variable
[Checkpatch]
CHECK: Alignment should match open parenthesis
#70: FILE: drivers/w1/w1.c:849:
+ if (iter->reg_num.family == id->family &&
+ iter->reg_num.id == id->id &&
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-12 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 22:49 Jakob Koschel
2023-05-12 7:27 ` Krzysztof Kozlowski
2023-05-12 10:19 ` Jakob Koschel
2023-05-12 10:26 ` Krzysztof Kozlowski [this message]
2023-05-12 11:17 ` Jakob Koschel
2023-05-12 11:23 ` Krzysztof Kozlowski
2023-05-12 11:28 ` Jakob Koschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a57688-6e9a-a21d-41cb-978a274c8b2b@kernel.org \
--to=krzk@kernel.org \
--cc=jkl820.git@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®