mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Peter Zijlstra" <peterz@infradead.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Tim Bird" <tim.bird@am.sony.com>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output
Date: Thu, 27 Nov 2008 15:53:16 +0100	[thread overview]
Message-ID: <c62985530811270653y644295d6x57de6be7a51be667@mail.gmail.com> (raw)
In-Reply-To: <1227781146.4454.1369.camel@twins>

2008/11/27 Peter Zijlstra <peterz@infradead.org>:
> Furthermore, it would be really sweet if ftrace_printk() output would be
> at the right indentation level wrt the function it was called from. eg.
>
> CPU[000] -          do_sync_read() {
> CPU[000]              # sock: 0x12345 flag: 1
> CPU[000] -            sock_aio_read() {
> ...
> CPU[000] + 0.123    }
>
>
> Where the # line is the ftrace_printk() output.


I didn't think of ftrace_printk yet.
That's a good idea, this way we will see where the ftrace_printk was
called, in which
function at which depth....

Don't you think that would be better to have it as C comments.
We are in a C-style output and ftrace_printk are especially designed for
comments in a trace.
That would make sense to read:

       do_sync_read() {
          /* sock: 0x12345 flag: 1 */
          sock_aio_read() {
0.123 }

  reply	other threads:[~2008-11-27 14:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27  0:46 Frederic Weisbecker
2008-11-27  0:57 ` Frédéric Weisbecker
2008-11-27  1:08   ` Steven Rostedt
2008-11-27 12:53     ` Frédéric Weisbecker
2008-11-27 10:19 ` Peter Zijlstra
2008-11-27 14:53   ` Frédéric Weisbecker [this message]
2008-11-27 15:05     ` Ingo Molnar
2008-11-27 10:34 ` Ingo Molnar
2008-11-27 10:55   ` Peter Zijlstra
2008-11-27 11:29     ` Ingo Molnar
2008-11-27 13:18       ` Frédéric Weisbecker
2008-11-27 14:07       ` Steven Rostedt
2008-11-27 14:13         ` Ingo Molnar
2008-11-27 13:11     ` Frédéric Weisbecker
2008-11-27 14:03       ` Steven Rostedt
2008-11-27 13:06   ` Frédéric Weisbecker
2008-11-27 13:51     ` Ingo Molnar
2008-11-27 14:44       ` Frédéric Weisbecker
2008-11-27 14:46         ` Ingo Molnar
2008-11-27 14:58           ` Frédéric Weisbecker
2008-11-27 15:03             ` Ingo Molnar
2008-11-27 15:09               ` Frédéric Weisbecker
2008-11-27 15:31         ` Steven Rostedt
2008-11-27 15:51           ` Frédéric Weisbecker
2008-11-28 13:05           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530811270653y644295d6x57de6be7a51be667@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®