From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Tim Bird" <tim.bird@am.sony.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output
Date: Thu, 27 Nov 2008 15:58:25 +0100 [thread overview]
Message-ID: <c62985530811270658x47f4f950m6c4c71f8674d27f1@mail.gmail.com> (raw)
In-Reply-To: <20081127144648.GB4672@elte.hu>
2008/11/27 Ingo Molnar <mingo@elte.hu>:
>
> * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
>
>> >> > 0) 0.993 us | }
>> >> > +0) 11.649 us | }
>> >> > 0) | do_sync_read() {
>> >> > 0) | sock_aio_read() {
>> >> > 0) | __sock_recvmsg() {
>> >> > 0) | security_socket_recvmsg() {
>> >> > !0) 100.319 us | cap_socket_recvmsg();
>> >> > ---------------------------------------------------------
>>
>> I like it before the CPU number. The main purpose would be to scroll
>> quickly the file and find the overheads. That would be easy if set
>> as a first character.
>>
>> I will set it as a default disabled option.
>
> lets keep it default-enabled, ok? It makes sense.
Ok.
BTW I understand why it is better to have a "pipe" if there is no time:
0) | do_sync_read() {
0) | sock_aio_read() {
0) | __sock_recvmsg() {
0) | security_socket_recvmsg() {
But I don't see why it is necessary to have one just after the time:
!0) 100.319 us | cap_socket_recvmsg();
It appears to me as noise....
next prev parent reply other threads:[~2008-11-27 14:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 0:46 Frederic Weisbecker
2008-11-27 0:57 ` Frédéric Weisbecker
2008-11-27 1:08 ` Steven Rostedt
2008-11-27 12:53 ` Frédéric Weisbecker
2008-11-27 10:19 ` Peter Zijlstra
2008-11-27 14:53 ` Frédéric Weisbecker
2008-11-27 15:05 ` Ingo Molnar
2008-11-27 10:34 ` Ingo Molnar
2008-11-27 10:55 ` Peter Zijlstra
2008-11-27 11:29 ` Ingo Molnar
2008-11-27 13:18 ` Frédéric Weisbecker
2008-11-27 14:07 ` Steven Rostedt
2008-11-27 14:13 ` Ingo Molnar
2008-11-27 13:11 ` Frédéric Weisbecker
2008-11-27 14:03 ` Steven Rostedt
2008-11-27 13:06 ` Frédéric Weisbecker
2008-11-27 13:51 ` Ingo Molnar
2008-11-27 14:44 ` Frédéric Weisbecker
2008-11-27 14:46 ` Ingo Molnar
2008-11-27 14:58 ` Frédéric Weisbecker [this message]
2008-11-27 15:03 ` Ingo Molnar
2008-11-27 15:09 ` Frédéric Weisbecker
2008-11-27 15:31 ` Steven Rostedt
2008-11-27 15:51 ` Frédéric Weisbecker
2008-11-28 13:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530811270658x47f4f950m6c4c71f8674d27f1@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®