mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] tracing/function-graph-tracer: signal interrupt triggering on output
Date: Wed, 10 Dec 2008 09:46:51 +0100	[thread overview]
Message-ID: <c62985530812100046l69ca7019j545fed604c373efa@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0812092111510.19875@gandalf.stny.rr.com>

2008/12/10 Steven Rostedt <rostedt@goodmis.org>:
>
> On Tue, 9 Dec 2008, Frederic Weisbecker wrote:
>
>> This patchset adds all the features to draw hardirq triggering on output
>> for the function graph tracer.
>> An example is given on the third patch.
>>
>> Just one question, on recordmcount.pl:
>>
>> my %text_sections = (
>>       ".text" => 1,
>>       ".sched.text" => 1,
>>       ".spinlock.text" => 1,
>>
>> The .sched.text section is included inside .text, it's a subsection, I'm not sure
>> it's necessary to add it in text_sections. In doubt I added the new .irqentry.text
>>
>
> Matters what objdump -dr shows.
>
> $ objdump -dr kernel/sched.o | grep 'Disassembly'
> Disassembly of section .text:
> Disassembly of section .cpuinit.text:
> Disassembly of section .init.text:
> Disassembly of section .sched.text:
>
> Yep, .sched.text is needed.  It is not about what gets linked by the
> linker. It is about what objdump shows, which is what recordmcount.pl uses
> to determine whether or not to record the mcount callers in that section.


Ok. I looked at a disassembly objdump on vmlinux to find those
subsections and didn't find it.
But I didn't see that recordmcount did its work on each build folder,
I guess that these sections are
visible on the objects found in the subdirectories....

Thanks.

  reply	other threads:[~2008-12-10  8:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <493EF64D.50804@gmail.com>
2008-12-09 22:56 ` Frederic Weisbecker
2008-12-12 10:14   ` Ingo Molnar
2008-12-12 11:27     ` Frédéric Weisbecker
2008-12-13  7:49       ` Ingo Molnar
2008-12-13 14:26         ` Frédéric Weisbecker
2008-12-13 15:22         ` Frédéric Weisbecker
2008-12-16 23:09           ` Ingo Molnar
2008-12-15  8:03         ` Peter Zijlstra
2008-12-10  2:14 ` Steven Rostedt
2008-12-10  8:46   ` Frédéric Weisbecker [this message]
2008-12-10  8:50     ` Wang Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530812100046l69ca7019j545fed604c373efa@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®