mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] tracing/function-graph-tracer: signal interrupt triggering on output
Date: Sat, 13 Dec 2008 16:22:25 +0100	[thread overview]
Message-ID: <c62985530812130722u5a4fbfcayd8c61dadbc5b1792@mail.gmail.com> (raw)
In-Reply-To: <20081213074930.GA4205@elte.hu>

2008/12/13 Ingo Molnar <mingo@elte.hu>:
> Another thing, i just noticed that ftrace_print() is broken in certain
> situations, for example a plain newline:
>
>        ftrace_printk("\n");
>
> printed via trace_pipe will print some weirdly concatenated line:
>
>           <...>-2994  [007]   406.498986: debug_show:          <...>-2994  [007]   406.498986:            <...>-2994  [007]   406.498986: debug_show:
>
> not via a separate, standalone, empty line.

I just tested with latest -tip and I don't any problem with it.
With a single ftrace_printk("\n") on might_sleep() I get:

           <...>-2739  [000]   145.692153: __might_sleep:
           <...>-2739  [000]   145.692155: __might_sleep:
           <...>-2739  [000]   145.692157: __might_sleep:
           <...>-2739  [000]   145.692158: __might_sleep:

with trace or trace_iter file.
Does it always occur or in rare situations?

  parent reply	other threads:[~2008-12-13 15:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <493EF64D.50804@gmail.com>
2008-12-09 22:56 ` Frederic Weisbecker
2008-12-12 10:14   ` Ingo Molnar
2008-12-12 11:27     ` Frédéric Weisbecker
2008-12-13  7:49       ` Ingo Molnar
2008-12-13 14:26         ` Frédéric Weisbecker
2008-12-13 15:22         ` Frédéric Weisbecker [this message]
2008-12-16 23:09           ` Ingo Molnar
2008-12-15  8:03         ` Peter Zijlstra
2008-12-10  2:14 ` Steven Rostedt
2008-12-10  8:46   ` Frédéric Weisbecker
2008-12-10  8:50     ` Wang Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530812130722u5a4fbfcayd8c61dadbc5b1792@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®