mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Cyrill Gorcunov" <gorcunov@gmail.com>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
	"Steven Rostedt" <srostedt@redhat.com>,
	"Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Alexander van Heukelum" <heukelum@fastmail.fm>
Subject: Re: [RFC] x86: entry_64 - introduce FTRACE_ frame macro
Date: Sat, 13 Dec 2008 15:46:03 +0100	[thread overview]
Message-ID: <c62985530812130646r6bcdf424o752f16458dd22914@mail.gmail.com> (raw)
In-Reply-To: <20081213082054.GA7559@localhost>

2008/12/13 Cyrill Gorcunov <gorcunov@gmail.com>:
> [Steven Rostedt - Fri, Dec 12, 2008 at 04:56:47PM -0500]
> ...
> | > Steve, here is how it could look like:
> | > (I liked first proposal more :)
> |
> | I see the confusion. In ftrace.h the function graph tracer config is not
> | inside CONFIG_FUNCTION_TRACER, even though it is dependent on it (or
> | was). OK, just do your first proposal then.
> |
> | -- Steve
> |
>
> ok, I sent it yesterday as
>
>        http://lkml.org/lkml/2008/12/12/301
>        [PATCH] x86: entry_64 - introduce FTRACE_ frame macro v2
>
> Ingo, will you pick it up?
>
>                - Cyrill -
>

Hi,

Looks good and clarify the asm bits.

I wonder if the function_graph_tracer should continue to necessarily
depend on the function tracer.
It was more simplier to do so but perhaps that could be avoided with
small modifications.

  reply	other threads:[~2008-12-13 14:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12 18:41 Cyrill Gorcunov
2008-12-12 20:19 ` Steven Rostedt
2008-12-12 20:47   ` Cyrill Gorcunov
2008-12-12 20:52     ` Steven Rostedt
2008-12-12 20:57       ` Cyrill Gorcunov
2008-12-12 20:59         ` Cyrill Gorcunov
2008-12-12 21:22         ` Steven Rostedt
2008-12-12 21:27           ` Cyrill Gorcunov
2008-12-12 21:35           ` Cyrill Gorcunov
2008-12-12 21:41             ` Cyrill Gorcunov
2008-12-12 21:56             ` Steven Rostedt
2008-12-13  8:20               ` Cyrill Gorcunov
2008-12-13 14:46                 ` Frédéric Weisbecker [this message]
2008-12-13 14:59                   ` Steven Rostedt
2008-12-13 15:28                     ` Frédéric Weisbecker
2008-12-13 15:16                   ` Cyrill Gorcunov
2008-12-13 15:26                     ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530812130646r6bcdf424o752f16458dd22914@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=heukelum@fastmail.fm \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®