From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes
Date: Tue, 29 Jul 2025 08:21:00 +0200 [thread overview]
Message-ID: <c661130c-3d18-4e6c-9c63-ac4c10c415de@linaro.org> (raw)
In-Reply-To: <CAP6Zq1gN28y-6_OwnzMbJ+EiubtABVw+FUqbmAo5bvBW-5tDdw@mail.gmail.com>
On 28/07/2025 14:12, Tomer Maimon wrote:
>>> +
>>> + mdio0: mdio@0 {
>>
>> Huh... this should fail checks. It's not MMIO node, is it?
> No, it's MDIO node,
> https://elixir.bootlin.com/linux/v6.16-rc7/source/Documentation/devicetree/bindings/net/mdio-gpio.yaml#L48
> Should I modify the node name? If yes, which node name should I use?
>>
>>
>>> + compatible = "virtual,mdio-gpio";
>>
>> where is the reg?
> It does not include reg in the mother node, but only in the child.
You put the unit address...
>>
>> Please confirm that you introduced no new dtbs_check W=1 warnings.
I need you to answer this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-29 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 13:53 [PATCH v1 0/2] arm64: dts: nuvoton: Add NPCM845 SoC and EVB support Tomer Maimon
2025-07-17 13:53 ` [PATCH v1 1/2] arm64: dts: nuvoton: npcm845: Add peripheral nodes Tomer Maimon
2025-07-17 14:04 ` Krzysztof Kozlowski
2025-07-28 11:30 ` Tomer Maimon
2025-07-29 6:21 ` Krzysztof Kozlowski
2025-07-29 13:25 ` Tomer Maimon
2025-07-17 13:53 ` [PATCH v1 2/2] arm64: dts: nuvoton: npcm845-evb: " Tomer Maimon
2025-07-17 14:25 ` Krzysztof Kozlowski
2025-07-28 12:12 ` Tomer Maimon
2025-07-29 6:21 ` Krzysztof Kozlowski [this message]
2025-07-29 13:16 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c661130c-3d18-4e6c-9c63-ac4c10c415de@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®