Re: [PATCH 5/5] crypto: qat - add support for 420xx devices

Re: [PATCH 5/5] crypto: qat - add support for 420xx devices

[Geert Uytterhoeven]

[-- Attachment #1: Type: text/plain, Size: 2244 bytes --]

 	Hi Jie,

On Fri, 15 Dec 2023, Jie Wang wrote:
> Add support for 420xx devices by including a new device driver that
> supports such devices, updates to the firmware loader and capabilities.
>
> Compared to 4xxx devices, 420xx devices have more acceleration engines
> (16 service engines and 1 admin) and support the wireless cipher
> algorithms ZUC and Snow 3G.
>
> Signed-off-by: Jie Wang <jie.wang@intel.com>
> Co-developed-by: Dong Xie <dong.xie@intel.com>
> Signed-off-by: Dong Xie <dong.xie@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Thanks for your patch, which is now commit fcf60f4bcf54952c ("crypto:
qat - add support for 420xx devices") in crypto/master

> --- a/drivers/crypto/intel/qat/Kconfig
> +++ b/drivers/crypto/intel/qat/Kconfig
> @@ -59,6 +59,17 @@ config CRYPTO_DEV_QAT_4XXX
> 	  To compile this as a module, choose M here: the module
> 	  will be called qat_4xxx.
>
> +config CRYPTO_DEV_QAT_420XX
> +	tristate "Support for Intel(R) QAT_420XX"
> +	depends on PCI && (!CPU_BIG_ENDIAN || COMPILE_TEST)

These dependencies suggest that the QAT_420XX device can be present and
used on any little-endian system that supports PCIe (arm64, MIPS,
PowerPC, RISC-V, ...).

However, [1] says QAT is only present on intel Atom® C5000, P5300, and
P5700 processors, implying the dependency should rather be

     depends on PCI && (X86_64 || COMPILE_TEST)

Which one is correct?

[1] https://www.intel.com/content/www/us/en/architecture-and-technology/intel-quick-assist-technology-overview.html

> +	select CRYPTO_DEV_QAT
> +	help
> +	  Support for Intel(R) QuickAssist Technology QAT_420xx
> +	  for accelerating crypto and compression workloads.
> +
> +	  To compile this as a module, choose M here: the module
> +	  will be called qat_420xx.
> +
> config CRYPTO_DEV_QAT_DH895xCCVF
> 	tristate "Support for Intel(R) DH895xCC Virtual Function"
> 	depends on PCI && (!CPU_BIG_ENDIAN || COMPILE_TEST)

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds

Re: [PATCH 5/5] crypto: qat - add support for 420xx devices

[Cabiddu, Giovanni]

Hi Geert,

On Tue, Dec 26, 2023 at 12:31:20PM +0100, Geert Uytterhoeven wrote:
> On Fri, 15 Dec 2023, Jie Wang wrote:
> > --- a/drivers/crypto/intel/qat/Kconfig
> > +++ b/drivers/crypto/intel/qat/Kconfig
> > @@ -59,6 +59,17 @@ config CRYPTO_DEV_QAT_4XXX
> > 	  To compile this as a module, choose M here: the module
> > 	  will be called qat_4xxx.
> > 
> > +config CRYPTO_DEV_QAT_420XX
> > +	tristate "Support for Intel(R) QAT_420XX"
> > +	depends on PCI && (!CPU_BIG_ENDIAN || COMPILE_TEST)
> 
> These dependencies suggest that the QAT_420XX device can be present and
> used on any little-endian system that supports PCIe (arm64, MIPS,
> PowerPC, RISC-V, ...).
> 
> However, [1] says QAT is only present on intel Atom® C5000, P5300, and
> P5700 processors, implying the dependency should rather be
> 
>     depends on PCI && (X86_64 || COMPILE_TEST)
> 
> Which one is correct?
Thanks for spotting this.

For this particular device it should be X86_64.

Plug-in cards devices (e.g. DH895xCC), instead, should stay !CPU_BIG_ENDIAN
as they can be used on any little-endian system.

I'm going to send a patch to change this.

-- 
Giovanni