Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Neil Armstrong <narmstrong@baylibre.com>]

On 01/12/2017 10:40, Philippe Ombredanne wrote:
> Neil,
> 
> On Fri, Dec 1, 2017 at 10:19 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Hi Philippe,
>>
>> On 01/12/2017 10:02, Philippe Ombredanne wrote:
>>> On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>> On 30/11/2017 01:39, Shawn Guo wrote:
>>>>> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>>>>>> This patch adds support for the Variscite DART-MX6 SoM with :
>>>>>> - i.MX6 Quad or Dual Lite SoC
>>>>>> - 1Gb/2Gb LPDDR2
>>>>>> - 4-64 GB eMMC
>>>>>> - Camera Interface
>>>>>> - HDMI+CEC interface
>>>>>> - LVDS / DSI / Parallel RGB interfaces
>>>>>> - Ethernet RGMII interface
>>>>>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>>>>>> - SD/MMC/SDIO interface
>>>>>> - USB Host + USB OTG interface
>>>>>> - I2C interfaces
>>>>>> - SPI interfaces
>>>>>> - PCI-Express 2.0 interface
>>>>>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>>>>>> - Digital Audio interface
>>>>>> - S/PDIF interface
>>>>>>
>>>>>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>>>>>
>>>>>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>>>>>> along the default pinmuxing to be enabled by the board dts file.
>>>>>>
>>>>>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>>>>>
>>>>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>
>>>>> Looks pretty good.  Only a couple of minor comments.
>>>>>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>>>>>  1 file changed, 504 insertions(+)
>>>>>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>> new file mode 100644
>>>>>> index 0000000..fd2520b
>>>>>> --- /dev/null
>>>>>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>> @@ -0,0 +1,504 @@
>>>>>> +/*
>>>>>> + * Support for Variscite DART-MX6 Module
>>>>>> + *
>>>>>> + * Copyright 2017 BayLibre, SAS
>>>>>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>>>>>> + *
>>>>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>>>> + */
>>>
>>> Should this be instead on the first line with a // comment style if
>>> possible, right?
>>
>> I just saw this right now.
>>
>> Damn, I just sent a v5...
>>
>>>
>>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>
>>> Thomas has sent a first doc patch [1] set and is working on an updated
>>> version.  Jonathan also wrote a nice background article on the topic
>>> at LWN [2].
>>>
>>> Linus explained why he wants the // comment style and a first line
>>> location on the list too.
>>>
>>> [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
>>> [2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
>>>
> 
> Sorry for wrecking your workflow with a smallish comment related
> comment and I am grateful that you consider this.

No problem, I understand your PoV even if the // comment is still dumb
to use in /* */ only commented files.

> 
> Thomas (tglx) is working on updated doc patches as soon as his real
> time clock yields a few ticks for doc work...
> The point is that Greg pushed already 10K+ file updates with proper
> SPDX ids.... I chipped in a bit there and there are still eventually
> 60k+ files to go to have a uniform and simplified licensing
> kernel-wide.

No problem, but maybe it would be time to actually tell all the maintainers
about this new policy, so we can start applying it.

> 
> So, every little bit to help avoiding drift and regress is helpful.
> Linus request for using // is to make this unambiguously greppable.

Well the "SPDX-Licence-Identifier: (.*)$" seems pretty greppable for
me... anyway we will comply.

> 
> The selfish benefit to me is that  eventually I will be able to send
> to the trash my license scanner in the future [1] (we use it to help
> cleanup the kernel FWIW) and replace this with a good' ole grep once
> everyone on earth use clean and greppable licensing... The kernel is
> setting the pace there for the whole FLOSS world and I hope this will
> snow ball, but hope is not a strategy! Once the kernel is done, I will
> have only more or less 100 billion+ file left to clean after that ;)
> 
> [1] https://github.com/nexB/scancode-toolkit
> 

Neil