From: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, bryan.odonoghue@linaro.org,
ilpo.jarvinen@linux.intel.com, hansg@kernel.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V3 1/5] dt-bindings: embedded-controller: Add EC bindings for Qualcomm reference devices
Date: Mon, 9 Mar 2026 17:05:13 +0530 [thread overview]
Message-ID: <c6820604-d1a9-42dc-bcd7-821aeb1b09c7@oss.qualcomm.com> (raw)
In-Reply-To: <20260309-amorphous-archetypal-impala-8a0e1d@quoll>
On 3/9/2026 12:53 PM, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 05:06:42AM +0530, Sibi Sankar wrote:
>> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>>
>> Add bindings for the EC firmware running on Hamoa/Purwa and Glymur
>> reference devices, which run on IT8987 and Nuvoton MCUs respectively.
>>
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> ---
>> .../embedded-controller/qcom,hamoa-ec.yaml | 52 +++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
>> new file mode 100644
>> index 000000000000..ea093b71d269
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Hamoa Embedded Controller.
> Please implement the feedback from v2.
Ack, sorry missed it.
>
>> +
>> +maintainers:
>> + - Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> +
>> +description:
>> + Qualcomm Snapdragon based Hamoa/Purwa and Glymur reference devices have an
>> + EC running on IT8987 and Nuvoton MCU chips respectively. The EC handles things
>> + like fan control, temperature sensors, access to EC internal state changes.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,glymur-nuvoton-ec
> nuvoton is name of the company, so it's too generic to describe a
> component. It's like calling it "qcom,glymur-qcom-ec". How many EC do
> you have there?
Ack, will get this updated.
>> + - qcom,hamoa-it8987-ec
> I don't understand this compatible. You already have hamoa.
>
>> + - const: qcom,hamoa-ec
> So which EC is this?
Will update the compatibles when consensus is achieved
on patch 4 thread.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-03-09 11:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 23:36 [PATCH V3 0/5] Add driver for EC found on " Sibi Sankar
2026-03-08 23:36 ` [PATCH V3 1/5] dt-bindings: embedded-controller: Add EC bindings for " Sibi Sankar
2026-03-09 7:23 ` Krzysztof Kozlowski
2026-03-09 11:35 ` Sibi Sankar [this message]
2026-03-09 21:06 ` Dmitry Baryshkov
2026-03-10 5:10 ` Sibi Sankar
2026-03-08 23:36 ` [PATCH V3 2/5] platform: arm64: Add driver for EC found on " Sibi Sankar
2026-03-09 9:03 ` Stephan Gerhold
2026-03-09 10:04 ` Sibi Sankar
2026-03-09 11:47 ` Konrad Dybcio
2026-03-09 11:55 ` Stephan Gerhold
2026-03-09 12:10 ` Konrad Dybcio
2026-03-10 4:58 ` Sibi Sankar
2026-03-16 10:33 ` Konrad Dybcio
2026-03-10 6:18 ` kernel test robot
2026-03-10 6:29 ` kernel test robot
2026-03-08 23:36 ` [PATCH V3 3/5] arm64: dts: qcom: glymur-crd: Add Embedded controller node Sibi Sankar
2026-03-08 23:36 ` [PATCH V3 4/5] arm64: dts: qcom: x1-crd: " Sibi Sankar
2026-03-09 7:25 ` Krzysztof Kozlowski
2026-03-09 9:03 ` Sibi Sankar
2026-03-09 9:09 ` Krzysztof Kozlowski
2026-03-09 10:51 ` Sibi Sankar
2026-03-09 10:53 ` Krzysztof Kozlowski
2026-03-09 11:48 ` Konrad Dybcio
2026-03-10 7:10 ` Krzysztof Kozlowski
2026-03-09 11:50 ` Sibi Sankar
2026-03-09 21:13 ` Dmitry Baryshkov
2026-03-10 5:11 ` Sibi Sankar
2026-03-10 9:45 ` Konrad Dybcio
2026-03-08 23:36 ` [PATCH V3 5/5] arm64: dts: qcom: hamoa-iot-evk: " Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6820604-d1a9-42dc-bcd7-821aeb1b09c7@oss.qualcomm.com \
--to=sibi.sankar@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®