mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Nick Dyer <nick@shmanahar.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Benson Leung <bleung@chromium.org>,
	Alan Bowens <Alan.Bowens@atmel.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Chris Healy <cphealy@gmail.com>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Andrew Duggan <aduggan@synaptics.com>,
	James Chen <james.chen@emc.com.tw>, Dudley Du <dudl@cypress.com>,
	Andrew de los Reyes <adlr@chromium.org>,
	sheckylin@chromium.org, Peter Hutterer <peter.hutterer@who-t.net>,
	Florian Echtler <floe@butterbrot.org>,
	mchehab@osg.samsung.com, jon.older@itdev.co.uk,
	nick.dyer@itdev.co.uk
Subject: Re: [PATCH v7 0/11] Output raw touch data via V4L2
Date: Mon, 11 Jul 2016 08:09:56 +0200	[thread overview]
Message-ID: <c6825cf2-46c8-f08b-e6aa-130855d2639b@xs4all.nl> (raw)
In-Reply-To: <1467977164-17551-1-git-send-email-nick@shmanahar.org>

On 07/08/2016 01:25 PM, Nick Dyer wrote:
> This is a series of patches to add output of raw touch diagnostic data via V4L2
> to the Atmel maXTouch and Synaptics RMI4 drivers.
> 
> It's a rewrite of the previous implementation which output via debugfs: it now
> uses a V4L2 device in a similar way to the sur40 driver.
> 
> We have a utility which can read the data and display it in a useful format:
>     https://github.com/ndyer/heatmap/commits/heatmap-v4l
> 
> These patches are also available from
>     https://github.com/ndyer/linux/commits/v4l-touch-v7-2016-07-08
> 
> I will also send a patch to update v4l2-compliance.

The series looks good, but it needs to be rebased due to this change:

http://www.spinics.net/lists/linux-media/msg101733.html

Regarding patch 3/11: as you may know we're moving from DocBook to sphinx for
the documentation in 4.8. The git branch with that code is here:

https://git.linuxtv.org/media_tree.git/log/?h=docs-next

If you can redo this patch 3/11 on top of that branch, then that would be
great.

Regards,

	Hans

> 
> Changes in v7:
> - Tested by Andrew Duggan and Chris Healy.
> - Update bus_info to add "rmi4:" bus.
> - Fix code style issues in sur40 changes.
> 
> Changes in v6:
> - Remove BUF_TYPE_TOUCH_CAPTURE, as discussed with Hans V touch devices will
>   use BUF_TYPE_VIDEO_CAPTURE.
> - Touch devices should now register CAP_VIDEO_CAPTURE: CAP_TOUCH just says that
>   this is a touch device, not a video device, but otherwise it acts the same.
> - Add some code to v4l_s_fmt() to set sensible default values for fields not
>   used by touch.
> - Improve naming/doc of RMI4 F54 report types.
> - Various minor DocBook fixes, and split to separate patch.
> - Update my email address.
> - Rework sur40 changes so that PIX_FMT_GREY is supported for backward
>   compatibility. Florian is it possible for you to test?
> 
> Changes in v5 (Hans Verkuil review):
> - Update v4l2-core:
>   - Add VFL_TYPE_TOUCH, V4L2_BUF_TYPE_TOUCH_CAPTURE and V4L2_CAP_TOUCH
>   - Change V4L2_INPUT_TYPE_TOUCH_SENSOR to V4L2_INPUT_TYPE_TOUCH
>   - Improve DocBook documentation
>   - Add FMT definitions for touch data
>   - Note this will need the latest version of the heatmap util
> - Synaptics RMI4 driver:
>   - Remove some less important non full frame report types
>   - Switch report type names to const char * array
>   - Move a static array to inside context struct
> - Split sur40 changes to a separate commit
> 
> Changes in v4:
> - Address nits from the input side in atmel_mxt_ts patches (Dmitry Torokhov)
> - Add Synaptics RMI4 F54 support patch
> 
> Changes in v3:
> - Address V4L2 review comments from Hans Verkuil
> - Run v4l-compliance and fix all issues - needs minor patch here:
>   https://github.com/ndyer/v4l-utils/commit/cf50469773f
> 
> Changes in v2:
> - Split pixfmt changes into separate commit and add DocBook
> - Introduce VFL_TYPE_TOUCH_SENSOR and /dev/v4l-touch
> - Remove "single node" support for now, it may be better to treat it as
>   metadata later
> - Explicitly set VFL_DIR_RX
> - Fix Kconfig
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

      parent reply	other threads:[~2016-07-11  6:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 11:25 Nick Dyer
2016-07-08 11:25 ` [PATCH v7 01/11] Input: atmel_mxt_ts - update MAINTAINERS email address Nick Dyer
2016-07-08 11:25 ` [PATCH v7 02/11] v4l2-core: Add support for touch devices Nick Dyer
2016-07-08 11:25 ` [PATCH v7 03/11] DocBook: add " Nick Dyer
2016-07-08 11:25 ` [PATCH v7 04/11] Input: atmel_mxt_ts - add support for T37 diagnostic data Nick Dyer
2016-07-08 11:25 ` [PATCH v7 05/11] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device Nick Dyer
2016-07-08 11:25 ` [PATCH v7 06/11] Input: atmel_mxt_ts - read touchscreen size Nick Dyer
2016-07-08 11:26 ` [PATCH v7 07/11] Input: atmel_mxt_ts - handle diagnostic data orientation Nick Dyer
2016-07-08 11:26 ` [PATCH v7 08/11] Input: atmel_mxt_ts - add diagnostic data support for mXT1386 Nick Dyer
2016-07-08 11:26 ` [PATCH v7 09/11] Input: atmel_mxt_ts - add support for reference data Nick Dyer
2016-07-08 11:26 ` [PATCH v7 10/11] Input: synaptics-rmi4 - add support for F54 diagnostics Nick Dyer
2016-07-08 11:26 ` [PATCH v7 11/11] Input: sur40 - use new V4L2 touch input type Nick Dyer
2016-07-08 11:27 ` [PATCH] v4l2-compliance: Changes to support touch sensors Nick Dyer
2016-07-11  6:09 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6825cf2-46c8-f08b-e6aa-130855d2639b@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=Alan.Bowens@atmel.com \
    --cc=adlr@chromium.org \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bleung@chromium.org \
    --cc=cphealy@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dudl@cypress.com \
    --cc=floe@butterbrot.org \
    --cc=james.chen@emc.com.tw \
    --cc=javier@osg.samsung.com \
    --cc=jon.older@itdev.co.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=nick.dyer@itdev.co.uk \
    --cc=nick@shmanahar.org \
    --cc=peter.hutterer@who-t.net \
    --cc=rydberg@bitmath.org \
    --cc=sheckylin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®