mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: loic pallardy <loic.pallardy@st.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: <ohad@wizery.com>, <lee.jones@linaro.org>,
	<linux-remoteproc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel@stlinux.com>
Subject: Re: [PATCH v2 07/19] remoteproc: Add new resource type for resource table spare bytes
Date: Mon, 19 Sep 2016 09:50:37 +0200	[thread overview]
Message-ID: <c6b1b933-6cf5-55eb-5391-33e520205b34@st.com> (raw)
In-Reply-To: <20160916171238.GH21438@tuxbot>



On 09/16/2016 07:12 PM, Bjorn Andersson wrote:
> On Fri 16 Sep 02:02 PDT 2016, loic pallardy wrote:
>
>>
>>
>> On 09/15/2016 07:54 PM, Bjorn Andersson wrote:
>>> On Wed 31 Aug 13:50 PDT 2016, Loic Pallardy wrote:
>>>
>>>> To allow resource appending to an existing resource table,
>>>> remoteproc framework should get information about resource
>>>> table spare area. With current resource table construction,
>>>> remoteproc is not able to identify by itself any free location.
>>>> This patch introduces a new resource type named RSC_SPARE which
>>>> allows firmware to define room for resource table extension.
>>>> Defined spare area will be used by remtoreproc to extend resource
>>>> table.
>>>>
>>>
>>> We don't need a dummy type for keeping track of the available room in
>>> the resource table in the loaded firmware. All we need to do is to look
>>> at the sh_size of the .resource_table section, which actually is what's
>>> returned in tablesz.
>>>
>> This is the size of the .resource_table section. Doesn't means that only
>> resource table is stored in.
>
> I'm not sure I'm getting the details of what you're saying here. Do you
> mean that there could be other things in the resource_table section or
> just the fact that it being a section doesn't give any information about
> how much space this thing will have in loaded form.
>
>> Today this is the assumption and we force firmware to respect this.
>>
>
> I find it unfortunate that this was put in section and that we just have
> to make assumptions on how this projects onto the loaded form.
>
>>> So the spare size is the difference between tablesz and the end of the
>>> last resource and if you need you can pad this when composing the
>>> firmware.
>>>
>> Proposal was to clearly identify the area for extension (whatever
>> .resource_table section is done). But if you agree on the fact
>> .resource_tabel section constains only resource table and eventualy room for
>> extension, I can indeed simply room detection.
>>
>
> Could you describe your use case for programmatically generate a
> resource table for a firmware without a .resource_table? I would like to
> understand the contract between the driver and the firmware when it
> comes to what should go into the resource table.

No I always consider .resource_table section.
You answer to my point just above. .resource_table section must contain 
only the resource table and nothing else. I'm fine with that.

I'll revert RSC_SPARE type.

Regards,
Loic
>
> Regards,
> Bjorn
>

  reply	other threads:[~2016-09-19  7:50 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 20:50 [PATCH v2 00/19] remoteproc: Allow platform-specific drivers to request resources Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 01/19] remoteproc: core: New API to add new resources to the resource table Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 02/19] remoteproc: core: Add function to dump " Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 03/19] remoteproc: core: Add function to amend an existing resource table entry Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 04/19] remoteproc: core: Add function to append a new " Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 05/19] remoteproc: core: Add function to over-ride current resource table Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 06/19] remoteproc: core: Add explicit message error if cached table failed Loic Pallardy
2016-09-01  7:09   ` Lee Jones
2016-09-08  9:40     ` loic pallardy
2016-08-31 20:50 ` [PATCH v2 07/19] remoteproc: Add new resource type for resource table spare bytes Loic Pallardy
2016-09-15 17:54   ` Bjorn Andersson
2016-09-16  9:02     ` loic pallardy
2016-09-16 17:12       ` Bjorn Andersson
2016-09-19  7:50         ` loic pallardy [this message]
2016-08-31 20:50 ` [PATCH v2 08/19] remoteproc: core: Associate action to resource request Loic Pallardy
2016-09-01  7:23   ` Lee Jones
2016-09-08  9:43     ` loic pallardy
2016-09-08 11:03       ` Lee Jones
2016-08-31 20:50 ` [PATCH v2 09/19] remoteproc: core: Finalize dump resource table function Loic Pallardy
2016-09-08  8:26   ` Lee Jones
2016-09-08  9:46     ` loic pallardy
2016-08-31 20:50 ` [PATCH v2 10/19] remoteproc: core: Add function to verify an existing resource in rsc table Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 11/19] remoteproc: core: Add function to get resource table spare bytes information Loic Pallardy
2016-09-08  8:32   ` Lee Jones
2016-09-08  9:47     ` loic pallardy
2016-08-31 20:50 ` [PATCH v2 12/19] remoteproc: core: Add vdev support and force mode to resource amending function Loic Pallardy
2016-09-08  8:48   ` Lee Jones
2016-09-08  9:49     ` loic pallardy
2016-09-08 11:02       ` Lee Jones
2016-09-08 13:11         ` loic pallardy
2016-08-31 20:50 ` [PATCH v2 13/19] remoteproc: core: Append resource only if spare resource present Loic Pallardy
2016-09-08  9:33   ` Lee Jones
2016-09-08  9:54     ` loic pallardy
2016-09-08 11:00       ` Lee Jones
2016-08-31 20:50 ` [PATCH v2 14/19] remoteproc: core: Add resource request action support Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 15/19] remoteproc: core: Add function to verify resource table consistency Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 16/19] remoteproc: core: Clean-up resource table sanity checks Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 17/19] remotecore: core: Add resource table pointer argument to rproc_handle_resource Loic Pallardy
2016-08-31 20:50 ` [PATCH v2 18/19] remoteproc: core: Add function to create remoteproc local resource table Loic Pallardy
2016-09-08 10:20   ` Lee Jones
2016-09-08 13:15     ` loic pallardy
2016-09-15 18:58   ` Bjorn Andersson
2016-09-19  7:46     ` loic pallardy
2016-08-31 20:50 ` [PATCH v2 19/19] remoteproc: core: Support empty resource tables Loic Pallardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6b1b933-6cf5-55eb-5391-33e520205b34@st.com \
    --to=loic.pallardy@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®