* [PATCH v2] checkpatch: ignore generated CamelCase defines and enum values
[not found] <CGME20201022184920eucas1p11fbcddc199309d9de8b57d9636d7f6fb@eucas1p1.samsung.com>
@ 2020-10-22 18:49 ` Łukasz Stelmach
2020-10-22 18:51 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Łukasz Stelmach @ 2020-10-22 18:49 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches, linux-kernel
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski,
Łukasz Stelmach
Ignore autogenerated CamelCase-like defines and enum values like
DRM_MODE_CONNECTOR_Unknown or ETHTOOL_LINK_MODE_Asym_Pause_BIT.
Syggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
Changes in v2
- use a more general regexp suggested by Joe Perches
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index fab38b493cef..7e67d565e903 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5295,6 +5295,8 @@ sub process {
#CamelCase
if ($var !~ /^$Constant$/ &&
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
+#Ignore some autogenerated defines and enum values
+ $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
#Ignore Page<foo> variants
$var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
#Ignore SI style variants like nS, mV and dB
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] checkpatch: ignore generated CamelCase defines and enum values
2020-10-22 18:49 ` [PATCH v2] checkpatch: ignore generated CamelCase defines and enum values Łukasz Stelmach
@ 2020-10-22 18:51 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-10-22 18:51 UTC (permalink / raw)
To: Łukasz Stelmach, Andy Whitcroft, linux-kernel, Andrew Morton
Cc: Bartłomiej Żolnierkiewicz, Marek Szyprowski
On Thu, 2020-10-22 at 20:49 +0200, Łukasz Stelmach wrote:
> Ignore autogenerated CamelCase-like defines and enum values like
> DRM_MODE_CONNECTOR_Unknown or ETHTOOL_LINK_MODE_Asym_Pause_BIT.
>
> Syggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> Changes in v2
> - use a more general regexp suggested by Joe Perches
Andrew, can you pick this up please?
> scripts/checkpatch.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index fab38b493cef..7e67d565e903 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5295,6 +5295,8 @@ sub process {
> #CamelCase
> if ($var !~ /^$Constant$/ &&
> $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> +#Ignore some autogenerated defines and enum values
> + $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
> #Ignore Page<foo> variants
> $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> #Ignore SI style variants like nS, mV and dB
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-22 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201022184920eucas1p11fbcddc199309d9de8b57d9636d7f6fb@eucas1p1.samsung.com>
2020-10-22 18:49 ` [PATCH v2] checkpatch: ignore generated CamelCase defines and enum values Łukasz Stelmach
2020-10-22 18:51 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®