From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Anusha Arun Nandi <anusha.nandi@oss.qualcomm.com>,
david@ixit.cz, andersson@kernel.org, konradybcio@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
bod@kernel.org, vladimir.zapolskiy@linaro.org,
loic.poulain@oss.qualcomm.com, mchehab@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
gjorgji.rosikopulos@oss.qualcomm.com,
jigarkumar.zala@oss.qualcomm.com,
hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com,
linux-media@vger.kernel.org,
krzysztof.kozlowski@oss.qualcomm.com, daniel@quora.org,
konrad.dybcio@oss.qualcomm.com, christopher.obbard@linaro.org,
alex.vinarskis@gmail.com
Subject: Re: [PATCH 1/3] phy: core: add generic MIPI C-PHY configuration API
Date: Mon, 19 Oct 2026 11:24:07 +0100 [thread overview]
Message-ID: <c6d963f5-a57e-4086-972a-4f04af2c5b42@linaro.org> (raw)
In-Reply-To: <a6d8514b-269c-441d-b280-4895b5f21fac@linaro.org>
On 18/10/2026 00:00, Bryan O'Donoghue wrote:
>> + unsigned int lanes;
>
> This statement and how you go about using the data aren't consistent.
Re-reading this.
unsigned int trios; would be fine too => data_lanes and lane_polarities
is a multiple of trios - always three - does it imply that the first
three entries in data-lanes == the first trio ?
Presumably.
That would work too.
data-lanes = <4 5 6 1 2 3>;
=>
trios = 2
=>
data_lanes[4, 5, 6, 1, 2, 3];
trio[0]:lanes == [4, 5, 6];
trio[1]:lanes == [1, 2, 3];
Probably "trios" instead of "lanes" makes more sense here and the driver
just always validates that count(data_lanes) % 3 is always false.
---
bod
next prev parent reply other threads:[~2026-10-19 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 4:17 [PATCH 0/3] phy: core, qcom-mipi-csi2: add generic MIPI C-PHY support Anusha Arun Nandi
2026-10-17 4:17 ` [PATCH 1/3] phy: core: add generic MIPI C-PHY configuration API Anusha Arun Nandi
2026-10-17 23:00 ` Bryan O'Donoghue
2026-10-19 10:24 ` Bryan O'Donoghue [this message]
2026-10-19 11:24 ` Bryan O'Donoghue
2026-10-19 14:15 ` Loic Poulain
2026-10-17 4:17 ` [PATCH 2/3] phy: qcom-mipi-csi2: Add sa8775p C-PHY support Anusha Arun Nandi
2026-10-17 23:19 ` Bryan O'Donoghue
2026-10-17 4:17 ` [PATCH 3/3] phy: qcom-mipi-csi2: Add sc7280 " Anusha Arun Nandi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d963f5-a57e-4086-972a-4f04af2c5b42@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=akapatra@quicinc.com \
--cc=alex.vinarskis@gmail.com \
--cc=andersson@kernel.org \
--cc=anusha.nandi@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=christopher.obbard@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel@quora.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=hariram.purushothaman@oss.qualcomm.com \
--cc=jigarkumar.zala@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®