From: Martin Kepplinger <martink@posteo.de>
To: Bijosh Thykkoottathil <bijosh.t@hotmail.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"christoph.muellner@theobroma-systems.com"
<christoph.muellner@theobroma-systems.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements
Date: Mon, 4 Jul 2016 14:23:30 +0200 [thread overview]
Message-ID: <c6fa0795-b316-2b65-955a-7b0acb92e027@posteo.de> (raw)
In-Reply-To: <KL1PR04MB12050202C107FB05AAB8EAEA80380@KL1PR04MB1205.apcprd04.prod.outlook.com>
Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil:
> Removed unwanted return statements from the function
> mma8452_set_freefall_mode.
You could've said "Don't unnecessarily save a return value.", but
whatever :) Thanks for your review!
>
> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/iio/accel/mma8452.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index e225d3c..d4a6d44 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state)
> val |= MMA8452_FF_MT_CFG_OAE;
> }
>
> - val = mma8452_change_config(data, chip->ev_cfg, val);
> - if (val)
> - return val;
> -
> - return 0;
> + return mma8452_change_config(data, chip->ev_cfg, val);
> }
>
> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
>
next parent reply other threads:[~2016-07-04 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <KL1PR04MB12050202C107FB05AAB8EAEA80380@KL1PR04MB1205.apcprd04.prod.outlook.com>
2016-07-04 12:23 ` Martin Kepplinger [this message]
2016-07-05 20:04 ` Jonathan Cameron
2016-07-06 14:14 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6fa0795-b316-2b65-955a-7b0acb92e027@posteo.de \
--to=martink@posteo.de \
--cc=bijosh.t@hotmail.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®