mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lyude@redhat.com
To: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	 linux-kernel@vger.kernel.org
Cc: Faith Ekstrand <faith.ekstrand@collabora.com>,
	Dave Airlie	 <airlied@redhat.com>,
	Leandro Ribeiro <leandro.ribeiro@collabora.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Kees Cook <kees@kernel.org>,
	Marco Crivellari	 <marco.crivellari@suse.com>,
	Simona Vetter <simona@ffwll.ch>,
	Pekka Paalanen	 <pekka.paalanen@collabora.com>,
	David Airlie <airlied@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <mripard@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	 Daniel Stone <daniels@collabora.com>,
	James Jones <jajones@nvidia.com>
Subject: Re: [PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes
Date: Tue, 21 Jul 2026 16:08:46 -0400	[thread overview]
Message-ID: <c7176459c23a43167a63ede73d2ba9b0c805445a.camel@redhat.com> (raw)
In-Reply-To: <20260720205541.257781-1-lyude@redhat.com>

I had thought that testing this on fbcon would be enough, but there is
still more issues with this series I found when adding these to the
kernel I dog food on my desktop. Will figure them out and send another
respin of this series asap

On Mon, 2026-07-20 at 16:43 -0400, Lyude Paul wrote:
> Recently a change went into the kernel to ensure that drivers which
> expose color formats which have alpha channels. This would cause
> nouveau
> to hit a WARN_ON when setting up cursors, since they do support
> blending
> - but we never bothered trying to hook up the controls for it to
> nouveau.
> 
> This fixes the issue by ensuring that nouveau always exposes a blend
> mode for any planes with alpha channels, regardless of whether or not
> we
> have control of the blend mode hooked up. If someone wants to add
> control for this in the future as well, it should be fairly easy to
> hook
> up with this.
> 
> Previous version:
> 	https://patchwork.freedesktop.org/patch/741031/
> 
> Lyude Paul (3):
>   drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func
>   drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state()
>   drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for
>     wndws
> 
>  drivers/gpu/drm/nouveau/dispnv50/curs507a.c |  3 ++
>  drivers/gpu/drm/nouveau/dispnv50/disp.c     |  4 +++
>  drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 40 +++++++++++++++++--
> --
>  drivers/gpu/drm/nouveau/dispnv50/wndw.h     | 11 ++++++
>  drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |  1 +
>  drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |  1 +
>  8 files changed, 55 insertions(+), 7 deletions(-)
> 
> 
> base-commit: b0a652436b892eb9a036a031b33099dca036faaa


      parent reply	other threads:[~2026-07-21 20:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 20:43 Lyude Paul
2026-07-20 20:43 ` [PATCH v2 1/3] drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func Lyude Paul
2026-07-20 20:43 ` [PATCH v2 2/3] drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state() Lyude Paul
2026-07-20 20:43 ` [PATCH v2 3/3] drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for wndws Lyude Paul
2026-07-21 20:08 ` lyude [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7176459c23a43167a63ede73d2ba9b0c805445a.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=dakr@kernel.org \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=faith.ekstrand@collabora.com \
    --cc=jajones@nvidia.com \
    --cc=kees@kernel.org \
    --cc=leandro.ribeiro@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marco.crivellari@suse.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=pekka.paalanen@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®