From: Johannes Thumshirn <jthumshirn@suse.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
maxg@mellanox.com,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/8] nvme: provide UUID value to userspace
Date: Thu, 1 Jun 2017 15:01:11 +0200 [thread overview]
Message-ID: <c71882ec-09ad-6104-0917-449abb8b27ae@suse.de> (raw)
In-Reply-To: <20170601124726.GF2845@localhost.localdomain>
On 06/01/2017 02:47 PM, Keith Busch wrote:
> FWIW, tools should have been using the 'wwid' attribute, which returns
> either EUI64 or NGUID so a unique identifier can be gotten from a
> single file without checking for the existence of either. That should
> help not break backward compatibility, but I've no idea if anything
> actually relies on 'uuid' returning the NGUID.
Yep, that's why I though I'd be clever and place this hack in there. I
think we can remove it in 1-2 years or so when most/all userspace has
adopted to the change (there shouldn't be too much apart from some hand
crafted udev rules anyways).
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-01 13:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 11:17 [PATCH v2 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-01 14:07 ` Max Gurtovoy
2017-06-01 11:17 ` [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-07 13:47 ` Andy Shevchenko
2017-06-07 13:49 ` Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-01 23:08 ` kbuild test robot
2017-06-02 0:14 ` kbuild test robot
2017-06-01 11:17 ` [PATCH v2 4/8] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 5/8] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 6/8] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-01 12:47 ` Keith Busch
2017-06-01 13:01 ` Johannes Thumshirn [this message]
2017-06-01 11:17 ` [PATCH v2 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c71882ec-09ad-6104-0917-449abb8b27ae@suse.de \
--to=jthumshirn@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®