* [PATCH] f2fs: quota: fix unused-label warning
@ 2026-09-17 14:21 Arnd Bergmann
2026-09-23 18:38 ` [f2fs-dev] " Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2026-09-17 14:21 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu, Jianan Huang
Cc: Arnd Bergmann, Kelvin Zhang, Daeho Jeong, Eric Biggers,
linux-f2fs-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added label causes a warning when QUOTA is turned off:
fs/f2fs/super.c: In function '__f2fs_remount':
fs/f2fs/super.c:3142:1: error: label 'restore_holder' defined but not used [-Werror=unused-label]
3142 | restore_holder:
| ^~~~~~~~~~~~~~
Fixes: 3f140a60c92a ("f2fs: quota: fix stale lock holder on remount failure")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/f2fs/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 6a2f09c61dcd..8358cdefa859 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3139,7 +3139,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
sbi->mount_opt = org_mount_opt;
sb->s_flags = old_sb_flags;
+#ifdef CONFIG_QUOTA
restore_holder:
+#endif
sbi->umount_lock_holder = NULL;
return err;
}
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: quota: fix unused-label warning
2026-09-17 14:21 [PATCH] f2fs: quota: fix unused-label warning Arnd Bergmann
@ 2026-09-23 18:38 ` Randy Dunlap
2026-09-30 8:01 ` Chao Yu
2026-09-30 17:20 ` [f2fs-dev] " patchwork-bot+f2fs
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-09-23 18:38 UTC (permalink / raw)
To: Arnd Bergmann, Jaegeuk Kim, Chao Yu, Jianan Huang
Cc: Kelvin Zhang, Arnd Bergmann, linux-kernel, linux-f2fs-devel,
Eric Biggers, Daeho Jeong
On 9/17/26 7:21 AM, Arnd Bergmann via Linux-f2fs-devel wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added label causes a warning when QUOTA is turned off:
>
> fs/f2fs/super.c: In function '__f2fs_remount':
> fs/f2fs/super.c:3142:1: error: label 'restore_holder' defined but not used [-Werror=unused-label]
> 3142 | restore_holder:
> | ^~~~~~~~~~~~~~
>
> Fixes: 3f140a60c92a ("f2fs: quota: fix stale lock holder on remount failure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/f2fs/super.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 6a2f09c61dcd..8358cdefa859 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -3139,7 +3139,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
> sbi->mount_opt = org_mount_opt;
> sb->s_flags = old_sb_flags;
>
> +#ifdef CONFIG_QUOTA
> restore_holder:
> +#endif
> sbi->umount_lock_holder = NULL;
> return err;
> }
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] f2fs: quota: fix unused-label warning
2026-09-17 14:21 [PATCH] f2fs: quota: fix unused-label warning Arnd Bergmann
2026-09-23 18:38 ` [f2fs-dev] " Randy Dunlap
@ 2026-09-30 8:01 ` Chao Yu
2026-09-30 17:20 ` [f2fs-dev] " patchwork-bot+f2fs
2 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2026-09-30 8:01 UTC (permalink / raw)
To: Arnd Bergmann, Jaegeuk Kim, Jianan Huang
Cc: chao, Arnd Bergmann, Kelvin Zhang, Daeho Jeong, Eric Biggers,
linux-f2fs-devel, linux-kernel
On 9/17/26 22:21, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added label causes a warning when QUOTA is turned off:
>
> fs/f2fs/super.c: In function '__f2fs_remount':
> fs/f2fs/super.c:3142:1: error: label 'restore_holder' defined but not used [-Werror=unused-label]
> 3142 | restore_holder:
> | ^~~~~~~~~~~~~~
>
> Fixes: 3f140a60c92a ("f2fs: quota: fix stale lock holder on remount failure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: quota: fix unused-label warning
2026-09-17 14:21 [PATCH] f2fs: quota: fix unused-label warning Arnd Bergmann
2026-09-23 18:38 ` [f2fs-dev] " Randy Dunlap
2026-09-30 8:01 ` Chao Yu
@ 2026-09-30 17:20 ` patchwork-bot+f2fs
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+f2fs @ 2026-09-30 17:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: jaegeuk, chao, jnhuang95, zhangxp1998, arnd, linux-kernel,
linux-f2fs-devel, ebiggers, daehojeong
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Thu, 17 Sep 2026 16:21:42 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added label causes a warning when QUOTA is turned off:
>
> fs/f2fs/super.c: In function '__f2fs_remount':
> fs/f2fs/super.c:3142:1: error: label 'restore_holder' defined but not used [-Werror=unused-label]
> 3142 | restore_holder:
> | ^~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [f2fs-dev] f2fs: quota: fix unused-label warning
https://git.kernel.org/jaegeuk/f2fs/c/4faeea625cf7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-30 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 14:21 [PATCH] f2fs: quota: fix unused-label warning Arnd Bergmann
2026-09-23 18:38 ` [f2fs-dev] " Randy Dunlap
2026-09-30 8:01 ` Chao Yu
2026-09-30 17:20 ` [f2fs-dev] " patchwork-bot+f2fs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®