* Re: [PATH v3] cgroup: add cgroup_favordynmods= command-line option
[not found] <20230926211617.42746-1-luizcap@amazon.com>
@ 2023-09-27 9:27 ` Michal Koutný
2023-09-27 11:10 ` [External] : " Kamalesh Babulal
1 sibling, 0 replies; 2+ messages in thread
From: Michal Koutný @ 2023-09-27 9:27 UTC (permalink / raw)
To: Luiz Capitulino
Cc: tj, lizefan.x, hannes, cgroups, linux-kernel, longman,
kamalesh.babulal, lcapitulino
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Tue, Sep 26, 2023 at 09:16:17PM +0000, Luiz Capitulino <luizcap@amazon.com> wrote:
> We have a need of using favordynmods with cgroup v1, which doesn't support
> changing mount flags during remount. Enabling CONFIG_CGROUP_FAVOR_DYNMODS at
> build-time is not an option because we want to be able to selectively
> enable it for certain systems.
>
> This commit addresses this by introducing the cgroup_favordynmods=
> command-line option. This option works for both cgroup v1 and v2 and also
> allows for disabling favorynmods when the kernel built with
> CONFIG_CGROUP_FAVOR_DYNMODS=y.
>
> Also, note that when cgroup_favordynmods=true favordynmods is never
> disabled in cgroup_destroy_root().
>
> Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
> ---
> .../admin-guide/kernel-parameters.txt | 4 ++++
> kernel/cgroup/cgroup.c | 18 ++++++++++++++----
> 2 files changed, 18 insertions(+), 4 deletions(-)
Thanks,
Reviewed-by: Michal Koutný <mkoutny@suse.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [External] : [PATH v3] cgroup: add cgroup_favordynmods= command-line option
[not found] <20230926211617.42746-1-luizcap@amazon.com>
2023-09-27 9:27 ` [PATH v3] cgroup: add cgroup_favordynmods= command-line option Michal Koutný
@ 2023-09-27 11:10 ` Kamalesh Babulal
1 sibling, 0 replies; 2+ messages in thread
From: Kamalesh Babulal @ 2023-09-27 11:10 UTC (permalink / raw)
To: Luiz Capitulino, tj, lizefan.x, hannes, cgroups, linux-kernel,
longman, mkoutny
Cc: lcapitulino
On 9/27/23 02:46, Luiz Capitulino wrote:
> We have a need of using favordynmods with cgroup v1, which doesn't support
> changing mount flags during remount. Enabling CONFIG_CGROUP_FAVOR_DYNMODS at
> build-time is not an option because we want to be able to selectively
> enable it for certain systems.
>
> This commit addresses this by introducing the cgroup_favordynmods=
> command-line option. This option works for both cgroup v1 and v2 and also
> allows for disabling favorynmods when the kernel built with
> CONFIG_CGROUP_FAVOR_DYNMODS=y.
>
> Also, note that when cgroup_favordynmods=true favordynmods is never
> disabled in cgroup_destroy_root().
>
> Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
The patch looks good to me, I have also boot tested it with combinations of
CONFIG_CGROUP_FAVOR_DYNMODS={y, n}, while passing the kernel parameter
cgroup_favordynmods={true, false} to the command line and works as expected.
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread