[PATCH] mailbox: mtk-gpueb: Add missing 'static' to mailbox ops struct

[PATCH] mailbox: mtk-gpueb: Add missing 'static' to mailbox ops struct

[Nicolas Frattaroli]

mtk_gpueb_mbox_ops should be declared static. However, due to its const
nature, this specifier was missed, as it compiled fine without it and
with no warning by the compiler.

arc-linux-gcc (GCC) 12.5.0 doesn't seem to like it however, so add the
static to fix that.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510100629.3nGvrhEU-lkp@intel.com/
Fixes: dbca0eabb821 ("mailbox: add MediaTek GPUEB IPI mailbox")
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
 drivers/mailbox/mtk-gpueb-mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-gpueb-mailbox.c b/drivers/mailbox/mtk-gpueb-mailbox.c
index 925bcf21f650..f6d2beccd91b 100644
--- a/drivers/mailbox/mtk-gpueb-mailbox.c
+++ b/drivers/mailbox/mtk-gpueb-mailbox.c
@@ -200,7 +200,7 @@ static bool mtk_gpueb_mbox_last_tx_done(struct mbox_chan *chan)
 	return !(readl(ch->ebm->mbox_ctl + GPUEB_MBOX_CTL_TX_STS) & BIT(ch->num));
 }
 
-const struct mbox_chan_ops mtk_gpueb_mbox_ops = {
+static const struct mbox_chan_ops mtk_gpueb_mbox_ops = {
 	.send_data = mtk_gpueb_mbox_send_data,
 	.startup = mtk_gpueb_mbox_startup,
 	.shutdown = mtk_gpueb_mbox_shutdown,

---
base-commit: cb6649f6217c0331b885cf787f1d175963e2a1d2
change-id: 20251013-mt8196-gpueb-mbox-fix-fe6c3053994f

Best regards,
-- 
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Re: [PATCH] mailbox: mtk-gpueb: Add missing 'static' to mailbox ops struct

[AngeloGioacchino Del Regno]

Il 13/10/25 10:09, Nicolas Frattaroli ha scritto:
> mtk_gpueb_mbox_ops should be declared static. However, due to its const
> nature, this specifier was missed, as it compiled fine without it and
> with no warning by the compiler.
> 
> arc-linux-gcc (GCC) 12.5.0 doesn't seem to like it however, so add the
> static to fix that.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510100629.3nGvrhEU-lkp@intel.com/
> Fixes: dbca0eabb821 ("mailbox: add MediaTek GPUEB IPI mailbox")
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>