mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Genes Lists <lists@sapience.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-kernel@vger.kernel.org, 	akpm@linux-foundation.org,
	torvalds@linux-foundation.org, stable@vger.kernel.org,
	 linux-media@vger.kernel.org, bingbu.cao@intel.com,
	Rodrigo Vivi	 <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	 Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	 intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org
Subject: Re: Linux 6.12.4 - crash dma_alloc_attrs+0x12b via ipu6
Date: Tue, 10 Dec 2024 10:40:52 -0500	[thread overview]
Message-ID: <c7c1d564ed3d6612c132f0e5e9f45a18306877e0.camel@sapience.com> (raw)
In-Reply-To: <2024121001-senator-raffle-a371@gregkh>


[-- Attachment #1.1: Type: text/plain, Size: 4043 bytes --]

On Tue, 2024-12-10 at 13:37 +0100, Greg Kroah-Hartman wrote:
> > t's a clue nonetheless.
> 
> 'git bisect' would be nice to run if possible...

Done:

a) One (hopefully) small caveat :
the very first bisect hit the 6.12.2 bug of missing commit b23decf8ac91
("sched: Initialize idle tasks only once").
I applied the commit and continued.

b) Result :

6ac269abab9ca5ae910deb2d3ca54351c3467e99 is the first bad commit
commit 6ac269abab9ca5ae910deb2d3ca54351c3467e99 (HEAD)
Author: Bingbu Cao <bingbu.cao@intel.com>
Date: Wed Oct 16 15:53:01 2024 +0800

media: ipu6: not override the dma_ops of device in driver

[ Upstream commit daabc5c64703432c4a8798421a3588c2c142c51b ]

DMA ops are a helper for architectures and not for drivers to override
the
DMA implementation. Driver should not override the DMA implementation.

This patch removes the dma_ops override from auxiliary device and adds
driver-internal helpers that use the actual DMA mapping APIs.

Fixes: 9163d83573e4 ("media: intel/ipu6: add IPU6 DMA mapping API and
MMU table")
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[Sakari Ailus: Fix the commit message a little.]
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

drivers/media/pci/intel/ipu6/ipu6-bus.c | 6 --
drivers/media/pci/intel/ipu6/ipu6-buttress.c | 21 +++++--
drivers/media/pci/intel/ipu6/ipu6-cpd.c | 18 +++---
drivers/media/pci/intel/ipu6/ipu6-dma.c | 195
+++++++++++++++++++++++++++++---------------------------------
drivers/media/pci/intel/ipu6/ipu6-dma.h | 34 ++++++++++-
drivers/media/pci/intel/ipu6/ipu6-fw-com.c | 14 ++---
6 files changed, 156 insertions(+), 132 deletions(-)

c) git bisect log

git bisect start
# status: waiting for both good and bad commits
# good: [d390303b28dabbb91b2d32016a4f72da478733b9] Linux 6.12.1
git bisect good d390303b28dabbb91b2d32016a4f72da478733b9
# status: waiting for bad commit, 1 good commit known
# bad: [61baee2dc5341c936e7fa7b1ca33c5607868de69] Linux 6.12.4
git bisect bad 61baee2dc5341c936e7fa7b1ca33c5607868de69
# bad: [2bc07714dc955a91d2923a440ea02c3cb3376b10] virtiofs: use pages
instead of pointer for kernel direct IO
git bisect bad 2bc07714dc955a91d2923a440ea02c3cb3376b10
# bad: [6f2648838ce1a9f2c432e84e38dec5d38412a551] wifi: wilc1000: Set
MAC after operation mode
git bisect bad 6f2648838ce1a9f2c432e84e38dec5d38412a551
# good: [e20117a105d4174c2daf4d6da17b92d757487e60] media: i2c:
max96717: clean up on error in max96717_subdev_init()
git bisect good e20117a105d4174c2daf4d6da17b92d757487e60
# bad: [74f21be9990a42dc2357bcf87a13e16c6998b90e] drm/vc4: hdmi: Avoid
hang with debug registers when suspended
git bisect bad 74f21be9990a42dc2357bcf87a13e16c6998b90e
# good: [dfdd0e8ff65dfc4183b622c3ffd8d8c5d572ca34] dt-bindings: cache:
qcom,llcc: Fix X1E80100 reg entries
git bisect good dfdd0e8ff65dfc4183b622c3ffd8d8c5d572ca34
# good: [b0cd515202cb31c89d7de46b103a7ff2de9de02b] media: ipu6: Fix DMA
and physical address debugging messages for 32-bit
git bisect good b0cd515202cb31c89d7de46b103a7ff2de9de02b
# bad: [3d48d0fbaaa74a04fb9092780a3f83dc4f3f8160] HID: hyperv:
streamline driver probe to avoid devres issues
git bisect bad 3d48d0fbaaa74a04fb9092780a3f83dc4f3f8160
# bad: [e3692460675bfe07f677711ead09a7a43934aa2f] pwm: Assume a
disabled PWM to emit a constant inactive output
git bisect bad e3692460675bfe07f677711ead09a7a43934aa2f
# bad: [11b0543efe54357b94dccb88dac2099c59358cd4] media: ipu6: remove
architecture DMA ops dependency in Kconfig
git bisect bad 11b0543efe54357b94dccb88dac2099c59358cd4
# bad: [6ac269abab9ca5ae910deb2d3ca54351c3467e99] media: ipu6: not
override the dma_ops of device in driver
git bisect bad 6ac269abab9ca5ae910deb2d3ca54351c3467e99
# first bad commit: [6ac269abab9ca5ae910deb2d3ca54351c3467e99] media:
ipu6: not override the dma_ops of device in driver




-- 
Gene


[-- Attachment #1.2: Type: text/html, Size: 5890 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2024-12-10 15:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 10:48 Linux 6.12.4 Greg Kroah-Hartman
2024-12-09 10:48 ` Greg Kroah-Hartman
2024-12-09 14:52 ` Linux 6.12.4 - crash dma_alloc_attrs+0x12b via ipu6 Genes Lists
2024-12-09 15:11   ` Genes Lists
2024-12-09 17:40     ` Stanislaw Gruszka
2024-12-09 18:04       ` Genes Lists
2024-12-09 15:18   ` Greg Kroah-Hartman
2024-12-09 16:12     ` Genes Lists
2024-12-10  7:15   ` Sakari Ailus
2024-12-10  8:58     ` Jani Nikula
2024-12-10 11:16       ` Genes Lists
2024-12-10 12:24         ` Jani Nikula
2024-12-10 12:37           ` Greg Kroah-Hartman
2024-12-10 15:18             ` Stanislaw Gruszka
2024-12-10 16:00               ` Genes Lists
2024-12-10 16:53               ` Genes Lists
2024-12-10 15:40             ` Genes Lists [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7c1d564ed3d6612c132f0e5e9f45a18306877e0.camel@sapience.com \
    --to=lists@sapience.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bingbu.cao@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®