mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krishna Manikandan <quic_mkrishn@quicinc.com>,
	Jonathan Marek <jonathan@marek.ca>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Srini Kandagatla <srinivas.kandagatla@linaro.org>,
	Rob Clark <robdclark@chromium.org>
Subject: Re: [PATCH v3 19/21] drm/msm/dpu: Implement CTL_PIPE_ACTIVE for v12.0 DPU
Date: Tue, 11 Mar 2025 14:42:43 +0100	[thread overview]
Message-ID: <c7c72397-c7d3-426d-b971-35b1cd213775@linaro.org> (raw)
In-Reply-To: <5rlcxx7pcu32hz3r4qufqcq2jzk2z4g2ep7reecpm2kksttwyi@66p2u4nwfzx6>

On 21/02/2025 17:26, Dmitry Baryshkov wrote:
> Minot nit below
> 
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
>> index 43a254cf57da571e2ec8aad38028477652f9283c..3e0bdd1100ebb0d302a852ceeaf8af86835e69a1 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
>> @@ -40,6 +40,7 @@
>>  #define   CTL_INTF_FLUSH                0x110
>>  #define   CTL_CDM_FLUSH                0x114
>>  #define   CTL_PERIPH_FLUSH              0x128
>> +#define   CTL_PIPE_ACTIVE               0x12C
> 
> lowercase hex, please.
Ack

Best regards,
Krzysztof

  reply	other threads:[~2025-03-11 13:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 15:24 [PATCH v3 00/21] drm/msm: Add support for SM8750 Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 01/21] dt-bindings: display/msm: dsi-controller-main: Combine if:then: entries Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 02/21] dt-bindings: display/msm: dsi-controller-main: Add missing minItems Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 03/21] dt-bindings: display/msm: dsi-phy-7nm: Add SM8750 Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 04/21] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 05/21] dt-bindings: display/msm: dp-controller: " Krzysztof Kozlowski
2025-02-24 17:22   ` Rob Herring (Arm)
2025-02-21 15:24 ` [PATCH v3 06/21] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 07/21] dt-bindings: display/msm: qcom,sm8750-mdss: " Krzysztof Kozlowski
2025-02-24 17:23   ` Rob Herring (Arm)
2025-02-21 15:24 ` [PATCH v3 08/21] drm/msm/dpu: Add missing "fetch" name to set_active_pipes() Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 09/21] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE on mixer reset Krzysztof Kozlowski
2025-02-21 16:11   ` Dmitry Baryshkov
2025-02-21 15:24 ` [PATCH v3 10/21] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE on ctl_path reset Krzysztof Kozlowski
2025-02-21 16:11   ` Dmitry Baryshkov
2025-02-21 15:24 ` [PATCH v3 11/21] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE before blend setup Krzysztof Kozlowski
2025-02-21 16:12   ` Dmitry Baryshkov
2025-02-21 15:24 ` [PATCH v3 12/21] drm/msm/dpu: Drop useless comments Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 13/21] drm/msm/dpu: Add LM_7, DSC_[67], PP_[67] and MERGE_3D_5 Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 14/21] drm/msm/dpu: Add handling of LM_6 and LM_7 bits in pending flush mask Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 15/21] drm/msm/dsi/phy: Add support for SM8750 Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 16/21] drm/msm/dsi: " Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 17/21] drm/msm/dpu: " Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 18/21] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU Krzysztof Kozlowski
2025-02-21 16:25   ` Dmitry Baryshkov
2025-03-11 13:41     ` Krzysztof Kozlowski
2025-02-21 15:24 ` [PATCH v3 19/21] drm/msm/dpu: Implement CTL_PIPE_ACTIVE " Krzysztof Kozlowski
2025-02-21 16:26   ` Dmitry Baryshkov
2025-03-11 13:42     ` Krzysztof Kozlowski [this message]
2025-02-21 15:24 ` [PATCH v3 20/21] drm/msm/dpu: Implement LM crossbar " Krzysztof Kozlowski
2025-02-21 16:27   ` Dmitry Baryshkov
2025-02-21 15:24 ` [PATCH v3 21/21] drm/msm/mdss: Add support for SM8750 Krzysztof Kozlowski
2025-03-08  5:43 ` [PATCH v3 00/21] drm/msm: " Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7c72397-c7d3-426d-b971-35b1cd213775@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jonathan@marek.ca \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_mkrishn@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®