From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>,
Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Joonhoe Kim <26rote@gmail.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU
Date: Thu, 12 Nov 2026 11:01:37 +0800 [thread overview]
Message-ID: <c7d46cf6-04d3-4c77-b628-046693004891@oss.qualcomm.com> (raw)
In-Reply-To: <20261109-mammoth-of-delightful-potency-b1ede2@quoll>
On 11/9/2026 8:25 PM, Krzysztof Kozlowski wrote:
> On Mon, Nov 09, 2026 at 04:36:35PM +0800, Yongxing Mou wrote:
>> Kaanapali (SM8850) has two display GDSCs. CORE_GDSC supplies shared
>> MDSS hardware and most of the DPU, while INT2 GDSC supplies the
>> VIG2/VIG3/DMA5 source pipes. Without INT2 GDSC, these source pipes
>> remain inaccessible.
>>
>> Describe CORE and INT2 as power domains of the DPU device, matching
>> the hardware partitioning. INT2 only supplies DPU-local source pipes,
>> while CORE also remains attached to the parent MDSS device because it
>> supplies shared MDSS hardware. DPU performance-state votes on CORE are
>> propagated through the genpd hierarchy to its parent MMCX domain.
>>
>> Keep the widest valid power-domain constraint in dpu-common.yaml and
>> narrow it in each platform-specific binding. Require two domains and
>> their names for Kaanapali, while retaining the existing single-domain
>> constraint for all other DPU platforms.
>>
>> Repeat power-domains in qcom,sm8650-dpu.yaml because dtschema requires
>> power-domain-names to have a power-domains sibling in the same file.
>>
>> Tested-by: Joonhoe Kim <26rote@gmail.com>
>
> Drop
>
> Anyway, where did it happen? Nothing in v4, nothing in v3.
>
Sorry for this mistake, will drop it next version.
>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>> .../bindings/display/msm/dpu-common.yaml | 3 +-
>> .../bindings/display/msm/qcom,kaanapali-mdss.yaml | 4 ++-
>> .../bindings/display/msm/qcom,msm8998-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,qcm2290-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sc7180-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sc7280-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sc8180x-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sdm845-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sm6115-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sm6150-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sm7150-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sm8150-dpu.yaml | 3 ++
>> .../bindings/display/msm/qcom,sm8650-dpu.yaml | 34 ++++++++++++++++++++++
>> 13 files changed, 69 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> index 3f953aa5e6949..c67199011f263 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> @@ -26,7 +26,8 @@ properties:
>> maxItems: 1
>>
>> power-domains:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>>
>> operating-points-v2: true
>> opp-table:
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,kaanapali-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,kaanapali-mdss.yaml
>> index 9f935defd6b12..6d6391970d6b6 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,kaanapali-mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,kaanapali-mdss.yaml
>> @@ -125,7 +125,9 @@ examples:
>>
>> operating-points-v2 = <&mdp_opp_table>;
>>
>> - power-domains = <&rpmhpd RPMHPD_MMCX>;
>> + power-domains = <&mdss_gdsc>,
>> + <&mdss_int2_gdsc>;
>> + power-domain-names = "core", "int2";
>>
>> ports {
>> #address-cells = <1>;
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-dpu.yaml
>> index d5a64c8a921f1..bded43a34b87d 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-dpu.yaml
>> @@ -15,6 +15,9 @@ properties:
>> compatible:
>> const: qcom,msm8998-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
>> index 034d3df8d2470..6c1476a0faaf5 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
>> @@ -19,6 +19,9 @@ properties:
>> - const: qcom,shikra-dpu
>> - const: qcom,qcm2290-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
>> index 8137618237ce7..3fa0f02f44892 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
>> @@ -19,6 +19,9 @@ properties:
>> - qcom,sm6350-dpu
>> - qcom,sm6375-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml
>> index df9ec15ad6c3c..7703d9b017cfc 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-dpu.yaml
>> @@ -24,6 +24,9 @@ properties:
>> - qcom,sm8450-dpu
>> - qcom,sm8550-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8180x-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8180x-dpu.yaml
>> index a411126708b80..8e10f9e0d1769 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc8180x-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8180x-dpu.yaml
>> @@ -15,6 +15,9 @@ properties:
>> compatible:
>> const: qcom,sc8180x-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-dpu.yaml
>> index dc11fd421a27f..9dafe1d827e13 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-dpu.yaml
>> @@ -17,6 +17,9 @@ properties:
>> - qcom,sdm670-dpu
>> - qcom,sdm845-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-dpu.yaml
>> index 510eb6c193649..173c2f034241c 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-dpu.yaml
>> @@ -15,6 +15,9 @@ properties:
>> compatible:
>> const: qcom,sm6115-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: MDP register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-dpu.yaml
>> index 8cbf99f9fcba5..b8344ff8895ac 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-dpu.yaml
>> @@ -16,6 +16,9 @@ properties:
>> compatible:
>> const: qcom,sm6150-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
>> index c79b2d4428003..8e50942f3e1f2 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
>> @@ -15,6 +15,9 @@ properties:
>> compatible:
>> const: qcom,sm7150-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-dpu.yaml
>> index a88d22f30a602..b407bc3994620 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-dpu.yaml
>> @@ -17,6 +17,9 @@ properties:
>> - qcom,sm8150-dpu
>> - qcom,sm8250-dpu
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> reg:
>> items:
>> - description: Address offset and size for mdp register set
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> index aa0cf0ec5b93f..c3bf4e7ca1ffe 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> @@ -54,6 +54,15 @@ properties:
>> - const: core
>> - const: vsync
>>
>> + power-domains:
>> + minItems: 1
>> + maxItems: 2
>> +
>> + power-domain-names:
>> + items:
>> + - const: core
>> + - const: int2
>> +
>> required:
>> - compatible
>> - reg
>> @@ -61,6 +70,31 @@ required:
>> - clocks
>> - clock-names
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,kaanapali-dpu
>> + required:
>> + - compatible
>
> Droo required
>
>> + then:
>> + properties:
>> + power-domains:
>> + minItems: 2
>> +
>> + power-domain-names:
>> + minItems: 2
>
> How did you resolve my previous comment?
>
>> +
>> + required:
>> + - power-domain-names
>
> Why adding this?
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-11-12 3:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 8:36 [PATCH v5 0/3] drm/msm/dpu: Add INT2 GDSC power domain support for Kaanapali Yongxing Mou
2026-11-09 8:36 ` [PATCH v5 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU Yongxing Mou
2026-11-09 12:25 ` Krzysztof Kozlowski
2026-11-12 3:01 ` Yongxing Mou [this message]
2026-11-09 8:36 ` [PATCH v5 2/3] drm/msm/dpu: Attach CORE and INT2 power domains on Kaanapali Yongxing Mou
2026-11-09 12:26 ` Krzysztof Kozlowski
2026-11-12 3:02 ` Yongxing Mou
2026-11-09 8:36 ` [PATCH v5 3/3] arm64: dts: qcom: Add INT2 GDSC to Kaanapali DPU Yongxing Mou
2026-11-11 15:42 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7d46cf6-04d3-4c77-b628-046693004891@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=26rote@gmail.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_mkrishn@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®