mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexey Klimov <alexey.klimov@linaro.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	linux-sound@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 10/12] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier
Date: Thu, 22 May 2025 20:13:43 +0200	[thread overview]
Message-ID: <c7d5dbab-0a51-4239-811e-dc68cac18887@oss.qualcomm.com> (raw)
In-Reply-To: <20250522-rb2_audio_v3-v3-10-9eeb08cab9dc@linaro.org>

On 5/22/25 7:41 PM, Alexey Klimov wrote:
> One WSA881X amplifier is connected on QRB4210 RB2 board
> hence only mono speaker is supported. This amplifier is set
> to work in analog mode only. Also add required powerdown
> pin/gpio.
> 
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 6bce63720cfffd8e0e619937fb1f365cbbbcb283..4b878e585227ee6b3b362108be96aad99acba21d 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -270,6 +270,24 @@ zap-shader {
>  	};
>  };
>  
> +&i2c1 {
> +	clock-frequency = <400000>;
> +	status = "okay";
> +
> +	wsa881x: amplifier@f {
> +		compatible = "qcom,wsa8815";
> +		reg = <0x0f>;
> +		pinctrl-0 = <&wsa_en_active>;
> +		pinctrl-names = "default";
> +		clocks = <&q6afecc LPASS_CLK_ID_MCLK_2 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +		powerdown-gpios = <&lpass_tlmm 16 GPIO_ACTIVE_LOW>;
> +		mclk-gpios = <&lpass_tlmm 18 GPIO_ACTIVE_HIGH>;
> +		sound-name-prefix = "SpkrMono";
> +		#sound-dai-cells = <0>;
> +		#thermal-sensor-cells = <0>;
> +	};
> +};
> +
>  &i2c2_gpio {
>  	clock-frequency = <400000>;
>  	status = "okay";
> @@ -736,6 +754,14 @@ wcd_reset_n: wcd-reset-n-state {
>  		drive-strength = <16>;
>  		output-high;
>  	};
> +
> +	wsa_en_active: wsa-en-active-state {
> +		pins = "gpio106";

Are there two separate enable pins? Or is the powerdown-gpio something
else?

Konrad

  reply	other threads:[~2025-05-22 18:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22 17:40 [PATCH v3 00/12] qrb4210-rb2: add wsa audio playback and capture support Alexey Klimov
2025-05-22 17:40 ` [PATCH v3 01/12] ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs Alexey Klimov
2025-05-22 17:49   ` Krzysztof Kozlowski
2025-05-22 17:40 ` [PATCH v3 02/12] dt-bindings: arm: qcom-soc: ignore "wsa" from being selected as SoC component Alexey Klimov
2025-05-23  8:12   ` Krzysztof Kozlowski
2025-05-28 14:37     ` Alexey Klimov
2025-05-28 16:58       ` Konrad Dybcio
2025-05-29  6:58         ` Krzysztof Kozlowski
2025-05-29 16:34           ` Konrad Dybcio
2025-05-29 16:58             ` Krzysztof Kozlowski
2025-05-29 17:12               ` Konrad Dybcio
2025-05-29  6:38       ` Krzysztof Kozlowski
2025-05-22 17:40 ` [PATCH v3 03/12] ASoC: dt-bindings: qcom,wsa881x: extend description to analog mode Alexey Klimov
2025-05-22 17:45   ` Krzysztof Kozlowski
2025-05-27 20:34     ` Alexey Klimov
2025-05-28  5:58       ` Krzysztof Kozlowski
2025-05-22 17:40 ` [PATCH v3 04/12] ASoC: codecs: lpass-rx-macro: add sm6115 compatible Alexey Klimov
2025-05-22 17:49   ` Krzysztof Kozlowski
2025-05-27 16:42     ` Alexey Klimov
2025-05-22 17:40 ` [PATCH v3 05/12] ASoC: codecs: wsa881x: split into common and soundwire drivers Alexey Klimov
2025-05-29 10:05   ` Srinivas Kandagatla
2025-11-12 17:21     ` Alexey Klimov
2025-11-12 17:31       ` Srinivas Kandagatla
2025-05-22 17:40 ` [PATCH v3 06/12] ASoC: codecs: add wsa881x-i2c amplifier codec driver Alexey Klimov
2025-05-23 12:59   ` kernel test robot
2025-05-29 10:05   ` Srinivas Kandagatla
2025-11-12 17:16     ` Alexey Klimov
2025-11-12 17:24       ` Srinivas Kandagatla
2025-05-22 17:40 ` [PATCH v3 07/12] arm64: dts: qcom: sm6115: add LPASS devices Alexey Klimov
2025-05-22 17:52   ` Krzysztof Kozlowski
2025-05-27 16:32     ` Alexey Klimov
2025-05-27 17:03       ` Konrad Dybcio
2025-05-27 18:33       ` Krzysztof Kozlowski
2025-05-27 20:36         ` Alexey Klimov
2025-05-28  5:59           ` Krzysztof Kozlowski
2025-05-22 17:40 ` [PATCH v3 08/12] arm64: dts: qcom: sm4250: add description of soundwire and dmic pins Alexey Klimov
2025-05-22 18:12   ` Konrad Dybcio
2025-05-27 15:59     ` Alexey Klimov
2025-05-22 17:40 ` [PATCH v3 09/12] arm64: dts: qcom: qrb4210-rb2: add wcd937x codec support Alexey Klimov
2025-05-22 17:41 ` [PATCH v3 10/12] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier Alexey Klimov
2025-05-22 18:13   ` Konrad Dybcio [this message]
2025-05-27 15:55     ` Alexey Klimov
2025-05-27 20:59       ` Konrad Dybcio
2025-05-22 17:41 ` [PATCH v3 11/12] arm64: dts: qcom: qrb4210-rb2: add WSA audio playback support Alexey Klimov
2025-05-22 17:41 ` [PATCH v3 12/12] arm64: dts: qcom: qrb4210-rb2: add VA capture support Alexey Klimov
2025-05-22 18:16   ` Konrad Dybcio
2025-05-22 17:47 ` [PATCH v3 00/12] qrb4210-rb2: add wsa audio playback and " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7d5dbab-0a51-4239-811e-dc68cac18887@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=alexey.klimov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®