From: Jiri Slaby <jirislaby@kernel.org>
To: Haowen Bai <baihaowen@meizu.com>,
arnd@arndb.de, gregkh@linuxfoundation.org, dsterba@suse.com,
elder@linaro.org, jcmvbkbc@gmail.com
Cc: johan@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags
Date: Mon, 21 Mar 2022 07:03:09 +0100 [thread overview]
Message-ID: <c7e6ca16-87a6-dbff-a2ad-852671b81b84@kernel.org> (raw)
In-Reply-To: <1647831852-28973-1-git-send-email-baihaowen@meizu.com>
Hi,
the $SUBJ says:
"try: synclink_cs: ..."
but you actually meant "tty:".
On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/char/pcmcia/synclink_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
> // BIT7:parity error
> // BIT6:framing error
>
> - if (status & (BIT7 + BIT6)) {
> + if (status & (BIT7 | BIT6)) {
> if (status & BIT7)
> icount->parity++;
> else
--
js
suse labs
next prev parent reply other threads:[~2022-03-21 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 3:04 Haowen Bai
2022-03-21 6:03 ` Jiri Slaby [this message]
2022-03-21 6:11 ` 答复: " 白浩文
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e6ca16-87a6-dbff-a2ad-852671b81b84@kernel.org \
--to=jirislaby@kernel.org \
--cc=arnd@arndb.de \
--cc=baihaowen@meizu.com \
--cc=dsterba@suse.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®