* [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags
@ 2022-03-21 3:04 Haowen Bai
2022-03-21 6:03 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Haowen Bai @ 2022-03-21 3:04 UTC (permalink / raw)
To: arnd, gregkh, jirislaby, dsterba, elder, jcmvbkbc
Cc: johan, linux-kernel, Haowen Bai
This silences the following coccinelle warning:
drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
we will try to make code cleaner
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/char/pcmcia/synclink_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 78baba5..e6f2186 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
// BIT7:parity error
// BIT6:framing error
- if (status & (BIT7 + BIT6)) {
+ if (status & (BIT7 | BIT6)) {
if (status & BIT7)
icount->parity++;
else
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags
2022-03-21 3:04 [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags Haowen Bai
@ 2022-03-21 6:03 ` Jiri Slaby
2022-03-21 6:11 ` 答复: " 白浩文
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2022-03-21 6:03 UTC (permalink / raw)
To: Haowen Bai, arnd, gregkh, dsterba, elder, jcmvbkbc; +Cc: johan, linux-kernel
Hi,
the $SUBJ says:
"try: synclink_cs: ..."
but you actually meant "tty:".
On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/char/pcmcia/synclink_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
> // BIT7:parity error
> // BIT6:framing error
>
> - if (status & (BIT7 + BIT6)) {
> + if (status & (BIT7 | BIT6)) {
> if (status & BIT7)
> icount->parity++;
> else
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread* 答复: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags
2022-03-21 6:03 ` Jiri Slaby
@ 2022-03-21 6:11 ` 白浩文
0 siblings, 0 replies; 3+ messages in thread
From: 白浩文 @ 2022-03-21 6:11 UTC (permalink / raw)
To: Jiri Slaby, arnd, gregkh, dsterba, elder, jcmvbkbc; +Cc: johan, linux-kernel
Hi, sir
Ok, thank you for your reminder.
________________________________________
发件人: Jiri Slaby <jirislaby@kernel.org>
发送时间: 2022年3月21日 14:03:09
收件人: 白浩文; arnd@arndb.de; gregkh@linuxfoundation.org; dsterba@suse.com; elder@linaro.org; jcmvbkbc@gmail.com
抄送: johan@kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags
Hi,
the $SUBJ says:
"try: synclink_cs: ..."
but you actually meant "tty:".
On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/char/pcmcia/synclink_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
> // BIT7:parity error
> // BIT6:framing error
>
> - if (status & (BIT7 + BIT6)) {
> + if (status & (BIT7 | BIT6)) {
> if (status & BIT7)
> icount->parity++;
> else
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-21 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-21 3:04 [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags Haowen Bai
2022-03-21 6:03 ` Jiri Slaby
2022-03-21 6:11 ` 答复: " 白浩文
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®