mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Tiberiu Breana <tiberiu.a.breana@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: iio/accel/stk8ba50: Use common error handling code in stk8ba50_probe()
Date: Thu, 26 Oct 2017 19:09:09 +0200	[thread overview]
Message-ID: <c7ee7221-3feb-1e6c-5e57-abec8c350330@users.sourceforge.net> (raw)
In-Reply-To: <20171026174200.5c00b06d@archlinux>

> Again, a general kernel development rule is to float only one
> patch of a given type until you have had feedback on it.

Some update suggestions according also to this general source code
transformation pattern were already integrated in other software areas.


> These backwards goto cases are sufficiently different from your earlier
> patch that got reviews that,

They are required if you would ever like to support software refactorings
in directions which I propose occasionally.


> at most, you should have sent one to the list and then given time
> for it to be properly reviewed (up to a week on IIO list typically).

Did I present my ideas a bit too quick in this case?

Regards,
Markus

  reply	other threads:[~2017-10-26 17:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 20:15 [PATCH 0/2] iio/accel/stk8ba50: Fine-tuning for two function implementations SF Markus Elfring
2017-10-25 20:16 ` [PATCH 1/2] iio/accel/stk8ba50: Use common error handling code in stk8ba50_probe() SF Markus Elfring
2017-10-26 16:42   ` Jonathan Cameron
2017-10-26 17:09     ` SF Markus Elfring [this message]
2017-12-10 12:33     ` iio/…: Use common error handling code SF Markus Elfring
2017-12-10 16:08       ` Jonathan Cameron
2017-12-10 16:43         ` SF Markus Elfring
2017-12-10 19:45           ` Jonathan Cameron
2017-10-25 20:17 ` [PATCH 2/2] iio/accel/stk8ba50: Improve unlocking of a mutex in stk8ba50_read_raw() SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7ee7221-3feb-1e6c-5e57-abec8c350330@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tiberiu.a.breana@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome