From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
linux-iio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [bug report] iio: light: isl29018: Replace a variant of iio_get_acpi_device_name_and_data()
Date: Fri, 1 Nov 2024 15:10:38 +0100 [thread overview]
Message-ID: <c8405b33-8c7a-47c3-afd5-2e6c7e951cb4@web.de> (raw)
In-Reply-To: <54fac4a7-b601-40ce-8c00-d94807f5e214@stanley.mountain>
> Commit 14686836fb69 ("iio: light: isl29018: Replace a variant of
> iio_get_acpi_device_name_and_data()") from Oct 24, 2024 (linux-next),
> leads to the following Smatch static checker warning:
>
> drivers/iio/light/isl29018.c:724 isl29018_probe() error: uninitialized symbol 'ddata'.
> drivers/iio/light/ltr501.c:1514 ltr501_probe() error: uninitialized symbol 'ddata'.
…
How do you think about to extend the mentioned source code analysis tool any more?
See also further development ideas:
* ltr501_probe()
https://lore.kernel.org/linux-kernel/8c7a5bcc-1fdb-45af-8f0c-1f9b6f0cf058@web.de/
https://lkml.org/lkml/2024/11/1/745
* isl29018_probe()
Is there a need to perform a null pointer check also with the local variable “name”
Regards,
Markus
parent reply other threads:[~2024-11-01 14:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <54fac4a7-b601-40ce-8c00-d94807f5e214@stanley.mountain>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8405b33-8c7a-47c3-afd5-2e6c7e951cb4@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®