mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [bug report] iio: light: isl29018: Replace a variant of iio_get_acpi_device_name_and_data()
       [not found] <54fac4a7-b601-40ce-8c00-d94807f5e214@stanley.mountain>
@ 2024-11-01 14:10 ` Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2024-11-01 14:10 UTC (permalink / raw)
  To: Dan Carpenter, linux-iio, Andy Shevchenko
  Cc: LKML, Jonathan Cameron, Lars-Peter Clausen

> Commit 14686836fb69 ("iio: light: isl29018: Replace a variant of
> iio_get_acpi_device_name_and_data()") from Oct 24, 2024 (linux-next),
> leads to the following Smatch static checker warning:
>
>     drivers/iio/light/isl29018.c:724 isl29018_probe() error: uninitialized symbol 'ddata'.
>     drivers/iio/light/ltr501.c:1514 ltr501_probe() error: uninitialized symbol 'ddata'.
…

How do you think about to extend the mentioned source code analysis tool any more?

See also further development ideas:
* ltr501_probe()
  https://lore.kernel.org/linux-kernel/8c7a5bcc-1fdb-45af-8f0c-1f9b6f0cf058@web.de/
  https://lkml.org/lkml/2024/11/1/745

* isl29018_probe()
  Is there a need to perform a null pointer check also with the local variable “name”

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-11-01 14:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <54fac4a7-b601-40ce-8c00-d94807f5e214@stanley.mountain>
2024-11-01 14:10 ` [bug report] iio: light: isl29018: Replace a variant of iio_get_acpi_device_name_and_data() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®