* [PATCH] leds: blinkm: constify attribute_group structures.
@ 2017-08-04 6:25 Arvind Yadav
2017-08-04 19:57 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-04 6:25 UTC (permalink / raw)
To: jansimon.moeller, rpurdie, jacek.anaszewski, pavel
Cc: linux-leds, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/leds/leds-blinkm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 617fe97..d03ed6b 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -298,7 +298,7 @@ static ssize_t store_test(struct device *dev, struct device_attribute *attr,
NULL,
};
-static struct attribute_group blinkm_group = {
+static const struct attribute_group blinkm_group = {
.name = "blinkm",
.attrs = blinkm_attrs,
};
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: blinkm: constify attribute_group structures.
2017-08-04 6:25 [PATCH] leds: blinkm: constify attribute_group structures Arvind Yadav
@ 2017-08-04 19:57 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2017-08-04 19:57 UTC (permalink / raw)
To: Arvind Yadav, jansimon.moeller, rpurdie, pavel; +Cc: linux-leds, linux-kernel
Hi Arvind,
Thanks for the patch.
On 08/04/2017 08:25 AM, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/leds/leds-blinkm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index 617fe97..d03ed6b 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -298,7 +298,7 @@ static ssize_t store_test(struct device *dev, struct device_attribute *attr,
> NULL,
> };
>
> -static struct attribute_group blinkm_group = {
> +static const struct attribute_group blinkm_group = {
> .name = "blinkm",
> .attrs = blinkm_attrs,
> };
>
Applied to the for-next branch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-04 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04 6:25 [PATCH] leds: blinkm: constify attribute_group structures Arvind Yadav
2017-08-04 19:57 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®