From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Markus Elfring <Markus.Elfring@web.de>,
vulab@iscas.ac.cn, brcm80211-dev-list.pdl@broadcom.com,
brcm80211@lists.linux.dev, linux-wireless@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Erick Archer <erick.archer@outlook.com>,
Jacobe Zang <jacobe.zang@wesion.com>,
Kalle Valo <kvalo@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v2 RESEND] brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()
Date: Tue, 22 Apr 2025 13:33:04 +0200 [thread overview]
Message-ID: <c8a78b36-6d24-42bd-b9aa-2a03cd7a01db@broadcom.com> (raw)
In-Reply-To: <d4de3f9d-5748-4969-98c6-7d17395eef4b@web.de>
On 4/22/2025 12:43 PM, Markus Elfring wrote:
> …
>> brcmf_usb_dl_cmd() but dose not check its return value. The
> …
>
> Please avoid typos in such a change description.
Please avoid such a stupid comment and just indicate what you think is
wrong and give a proper suggestion to what is should be.
>
>> Add error handling for brcmf_usb_dl_cmd() to jump to error
>> handling path if the brcmf_usb_dl_cmd() fails and the
>> 'state.state' and the 'state.bytes' are uninitialized.
>
> This wording is improvable.
That is quite a generic wording you use there. Speak your mind and come
up with improved feedback.
>> Improve the error message to report more detailed error
>> information.
>
> Please offer such an adjustment by a separate update step.
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc3#n81
Nah. The changes are small and within context. The patch is small enough
to assure the bar is low enough for swift review. Splitting it up only
increases the burden.
Regards,
Arend
prev parent reply other threads:[~2025-04-22 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 4:22 Wentao Liang
2025-04-22 4:55 ` Arend Van Spriel
2025-04-22 10:43 ` Markus Elfring
2025-04-22 11:33 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a78b36-6d24-42bd-b9aa-2a03cd7a01db@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Markus.Elfring@web.de \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=christophe.jaillet@wanadoo.fr \
--cc=erick.archer@outlook.com \
--cc=jacobe.zang@wesion.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®