From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, brcm80211-dev-list.pdl@broadcom.com,
brcm80211@lists.linux.dev, linux-wireless@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Erick Archer <erick.archer@outlook.com>,
Jacobe Zang <jacobe.zang@wesion.com>,
Kalle Valo <kvalo@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v2 RESEND] brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()
Date: Tue, 22 Apr 2025 12:43:19 +0200 [thread overview]
Message-ID: <d4de3f9d-5748-4969-98c6-7d17395eef4b@web.de> (raw)
In-Reply-To: <20250422042203.2259-1-vulab@iscas.ac.cn>
…
> brcmf_usb_dl_cmd() but dose not check its return value. The
…
Please avoid typos in such a change description.
> Add error handling for brcmf_usb_dl_cmd() to jump to error
> handling path if the brcmf_usb_dl_cmd() fails and the
> 'state.state' and the 'state.bytes' are uninitialized.
This wording is improvable.
> Improve the error message to report more detailed error
> information.
Please offer such an adjustment by a separate update step.
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc3#n81
Regards,
Markus
next prev parent reply other threads:[~2025-04-22 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 4:22 Wentao Liang
2025-04-22 4:55 ` Arend Van Spriel
2025-04-22 10:43 ` Markus Elfring [this message]
2025-04-22 11:33 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4de3f9d-5748-4969-98c6-7d17395eef4b@web.de \
--to=markus.elfring@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=christophe.jaillet@wanadoo.fr \
--cc=erick.archer@outlook.com \
--cc=jacobe.zang@wesion.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®