* [PATCH] tracing/synthetic: Make lastcmd_mutex static
@ 2023-04-06 15:10 Steven Rostedt
2023-04-06 15:33 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2023-04-06 15:10 UTC (permalink / raw)
To: LKML, Linux Trace Kernel
Cc: Masami Hiramatsu, Mark Rutland, kernel test robot, Tze-nan Wu
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The lastcmd_mutex is only used in trace_events_synth.c and should be
static.
Link: https://lore.kernel.org/linux-trace-kernel/202304062033.cRStgOuP-lkp@intel.com/
Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/trace_events_synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index f0ff730125bf..d6a70aff2410 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -44,7 +44,7 @@ enum { ERRORS };
static const char *err_text[] = { ERRORS };
-DEFINE_MUTEX(lastcmd_mutex);
+static DEFINE_MUTEX(lastcmd_mutex);
static char *last_cmd;
static int errpos(const char *str)
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing/synthetic: Make lastcmd_mutex static
2023-04-06 15:10 [PATCH] tracing/synthetic: Make lastcmd_mutex static Steven Rostedt
@ 2023-04-06 15:33 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2023-04-06 15:33 UTC (permalink / raw)
To: Steven Rostedt, LKML, Linux Trace Kernel
Cc: Masami Hiramatsu, Mark Rutland, kernel test robot, Tze-nan Wu
On 4/6/2023 8:40 PM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> The lastcmd_mutex is only used in trace_events_synth.c and should be
> static.
>
> Link: https://lore.kernel.org/linux-trace-kernel/202304062033.cRStgOuP-lkp@intel.com/
>
> Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
You have just beat me in pushing this.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-- Mukesh
> ---
> kernel/trace/trace_events_synth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index f0ff730125bf..d6a70aff2410 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -44,7 +44,7 @@ enum { ERRORS };
>
> static const char *err_text[] = { ERRORS };
>
> -DEFINE_MUTEX(lastcmd_mutex);
> +static DEFINE_MUTEX(lastcmd_mutex);
> static char *last_cmd;
>
> static int errpos(const char *str)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-06 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 15:10 [PATCH] tracing/synthetic: Make lastcmd_mutex static Steven Rostedt
2023-04-06 15:33 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®