Re: [PATCH v5 1/2] arm64: dts: qcom: Add display support for QCS615

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 8/5/25 2:24 PM, Fange Zhang wrote:
> 
> 
> On 7/29/2025 7:17 PM, Konrad Dybcio wrote:
>> On 7/18/25 2:56 PM, Fange Zhang wrote:
>>> From: Li Liu <quic_lliu6@quicinc.com>
>>>
>>> Add display MDSS and DSI configuration for QCS615 platform.
>>> QCS615 has a DP port, and DP support will be added in a later patch.
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> Signed-off-by: Li Liu <quic_lliu6@quicinc.com>
>>> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
>>> ---
>>
>> [...]
>>
>>> +
>>> +            mdss_mdp: display-controller@ae01000 {
>>> +                compatible = "qcom,sm6150-dpu";
>>> +                reg = <0x0 0x0ae01000 0x0 0x8f000>,
>>> +                      <0x0 0x0aeb0000 0x0 0x2008>;
>>> +                reg-names = "mdp", "vbif";
>>> +
>>> +                clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>> +                     <&gcc GCC_DISP_HF_AXI_CLK>,
>>> +                     <&dispcc DISP_CC_MDSS_MDP_CLK>,
>>> +                     <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
>>> +                clock-names = "iface", "bus", "core", "vsync";
>>
>> 1 per line please, everywhere> +
> Got it will fix it in next patch>> +                assigned-clocks = <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
>>> +                assigned-clock-rates = <19200000>;
>>
>> Is this necessary?
> test pass without this, so will remove them in next patch>

You need to leave a \n before you start typing your reply, otherwise
the email text gets messed up (like above)

Konrad